Designate

eventlet 0.17.0 has broke dns.reversename.from_address()

Bug #1424621 reported by Kiall Mac Innes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Kiall Mac Innes
Designate 2015.1.0 "kilo"

Bug Description

eventlet 0.17.0 was released today (2015-02-23), and has caused some breakage for Designate.

eventlet monkey patches dnspython, and a change between 0.16.1 and 0.17.0 has broken API compatibility.

Reverting this eventet commit appears to solve the issue: https://github.com/eventlet/eventlet/commit/a6ce444265d36fb23361809d40da73caf4864487

    ipdb> reversename.from_address("192.168.1.1")
    *** ValueError: origin must be a Name or None

Documentation for dns.reversename: http://www.dnspython.org/docs/1.12.0/dns.reversename-module.html

Revision history for this message
Kiall Mac Innes (kiall) wrote :

Upstream eventlet bug filed @ https://github.com/eventlet/eventlet/issues/203

Revision history for this message
Kiall Mac Innes (kiall) wrote :

Upstream bug filed in the right place ;) https://bitbucket.org/eventlet/eventlet/issue/169/ipv6-patch-breaks-dnspython

Revision history for this message
Kiall Mac Innes (kiall) wrote :

openstack/requirements cap submitted at https://review.openstack.org/158287

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/158298

Changed in designate:
assignee: nobody → Kiall Mac Innes (kiall)
status: Triaged → In Progress
Revision history for this message
Kiall Mac Innes (kiall) wrote :

openstack/designate workaround submitted at https://review.openstack.org/#/c/158298/

This may/or may not be the full extent of the breakage, ideally we still land the openstack/requirements cap until a fixed eventlet is released.

Revision history for this message
Kiall Mac Innes (kiall) wrote :

Eventlet folks are working on a fix + bug fix release.. :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/158298
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=73657f89bc8c513d1cf35abd351bad2f6f1c5fd6
Submitter: Jenkins
Branch: master

commit 73657f89bc8c513d1cf35abd351bad2f6f1c5fd6
Author: Kiall Mac Innes <email address hidden>
Date: Mon Feb 23 13:56:05 2015 +0000

    Workaround eventlet 0.17's broken monkeypatching

    Change-Id: I6a4366f4203b91ce3a4e69fce308b993f447c31b
    Partial-Bug: 1424621

Kiall Mac Innes (kiall)
Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.