OpenStack Dashboard (Horizon)

"Items Per Page" help text needs to be more detailed

Bug #1431364 reported by Rob Cresswell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Ganesh
OpenStack Dashboard (Horizon) 8.0.0 "liberty"

Bug Description

The help text for "items per page" in the user settings should be extended to indicate that it only affects those tables that have API supported pagination. See https://bugs.launchpad.net/horizon/+bug/1331350 for further discussion on why this would be useful.

Help text is located here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/settings/user/forms.py#L45

Rob Cresswell (robcresswell-deactivatedaccount)
tags: added: low-hanging-fruit ux
Nikunj Aggarwal (nikunj2512)
Changed in horizon:
assignee: nobody → Nikunj Aggarwal (nikunj2512)
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Nikunj,

Just removed you from bug inline with our conversation earlier. Thanks!

Changed in horizon:
assignee: Nikunj Aggarwal (nikunj2512) → nobody
Sandhya Ganapathy (sandhya-ganapathy)
Changed in horizon:
assignee: nobody → Sandhya Ganapathy (sandhya-ganapathy)
Ganesh (ganeshna)
Changed in horizon:
assignee: Sandhya Ganapathy (sandhya-ganapathy) → Ganesh (ganeshna)
Ganesh (ganeshna)
Changed in horizon:
status: New → Confirmed
Ganesh (ganeshna)
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Ganesh (ganeshna) wrote :

Fix proposed:

Review: https://review.openstack.org/173889

Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
importance: Undecided → Low
Revision history for this message
Ganesh (ganeshna) wrote :

Hi,

Please review and give +2, so that the changes can be merged.

Thanks,
Ganesh

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/173889
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bd3ec44a46e9c11579dc035aacc37138d15c9e91
Submitter: Jenkins
Branch: master

commit bd3ec44a46e9c11579dc035aacc37138d15c9e91
Author: Ganesh Narayanan <email address hidden>
Date: Wed Apr 15 07:09:33 2015 -0700

    Added more details to items per page help text

    "Items per page" value setting is applicable only to those pages
    that have API supported pagination. For example, if "Items per page"
    value is set to say "3" and if we go to Admin > Identity Panel > Users
    page, more than "3" items will be displayed if present. This is
    confusing to users. So as part of this commit, the help text is modified
    to reflect this limitation.

    Change-Id: Ibbd4771829f0c312134eb275c797780be2b78410
    Closes-Bug: 1431364

Changed in horizon:
status: In Progress → Fix Committed
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
milestone: none → liberty-1
Doug Hellmann (doug-hellmann)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.