Designate

Message size passed to response.to_wire() max_size is too low

Bug #1435863 reported by Endre Karlson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Kiall Mac Innes
Designate 2015.1.0 "kilo"

Bug Description

This bug causes large AXFRs too raise a TooBig exception because it will set max_size to self.request_payload.

Endre Karlson (endre-karlson)
Changed in designate:
milestone: none → kilo-rc1
assignee: nobody → Endre Karlson (endre-karlson)
importance: Undecided → Medium
importance: Medium → High
Kiall Mac Innes (kiall)
Changed in designate:
status: New → Triaged
Endre Karlson (endre-karlson)
Changed in designate:
status: Triaged → Confirmed
Kiall Mac Innes (kiall)
Changed in designate:
importance: High → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167268

Changed in designate:
assignee: Endre Karlson (endre-karlson) → Kiall Mac Innes (kiall)
status: Confirmed → In Progress
OpenStack Infra (hudson-openstack)
Changed in designate:
assignee: Kiall Mac Innes (kiall) → Endre Karlson (endre-karlson)
OpenStack Infra (hudson-openstack)
Changed in designate:
assignee: Endre Karlson (endre-karlson) → Kiall Mac Innes (kiall)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/167268
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=c4d74fc79e6418a9a3cef6be5f38a828c9e20aa8
Submitter: Jenkins
Branch: master

commit c4d74fc79e6418a9a3cef6be5f38a828c9e20aa8
Author: Kiall Mac Innes <email address hidden>
Date: Tue Mar 24 15:12:59 2015 +0000

    Support mDNS response up to 65k

    Change-Id: Ie2b7306f0201e0f5f51f1bfb5216a778e2bbda65
    Closes-Bug: 1435863

Changed in designate:
status: In Progress → Fix Committed
Revision history for this message
stanzgy (stanzgy) wrote :

I have noticed that this patch just set a param 'max_size=65535' on response.to_wire().
Those big AXFRs with contents larger than 65535 will still have this problem.
Maybe we could do some further work on this issue.

Kiall Mac Innes (kiall)
Changed in designate:
status: Fix Committed → In Progress
status: In Progress → Triaged
Kiall Mac Innes (kiall)
Changed in designate:
assignee: Kiall Mac Innes (kiall) → nobody
Revision history for this message
Kiall Mac Innes (kiall) wrote :

Filed a new bug for over 65k @ bug 1439125

Changed in designate:
status: Triaged → Fix Committed
Tim Simmons (timsim)
Changed in designate:
assignee: nobody → Kiall Mac Innes (kiall)
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.