pt-upgrade erroneously reports number of diffs
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Low
|
Frank Cizmich | ||
Bug Description
pt-upgrade invariably reports the cause of reporting a class of querie as "Reporting class because there are 1000 row diffs.", even when the number of diffs is only a few.
sample output:
#------
# Hosts
#------
host1:
DSN: h=127.0.0.1,P=12345
hostname: santi
MySQL: MySQL Community Server (GPL) 5.6.17
host2:
DSN: h=127.0.0.1,P=12346
hostname: santi
MySQL: MySQL Community Server (GPL) 5.6.17
#######
# Query class 3530F787A2430DC8
#######
Reporting class because there are 1000 row diffs.
Total queries 3
Unique queries 3
Discarded queries 0
....
..
.
Related branches
- Daniel Nichter: Approve
-
Diff: 237 lines (+112/-16)5 files modifiedbin/pt-upgrade (+13/-8)
lib/UpgradeResults.pm (+13/-8)
t/pt-upgrade/samples/008/conf (+2/-0)
t/pt-upgrade/samples/008/fingerprint-grouping-and-max-examples-issue-1421405.log (+9/-0)
t/pt-upgrade/samples/008/fingerprint-grouping-and-max-examples-issue-1421405.txt (+75/-0)
| Changed in percona-toolkit: | |
| importance: | Undecided → Low |
| status: | New → Fix Committed |
| milestone: | none → 2.2.14 |
| assignee: | nobody → Frank Cizmich (frank-cizmich) |
| tags: | added: pt-upgrade |
| Frank Cizmich (frank-cizmich) wrote | #1 |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
It was erroneously reporting max number of rows in a class instead of number of diffs.
Fixed.