Canonical Click Reviewers tools (obsolete)

Failure to validate properly formatted webapp Exec lines

Bug #1441185 reported by Alexandre Abreu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Fix Released
Undecided
Alexandre Abreu

Bug Description

With an exec line such as:

Exec=webapp-container --enable-back-forward --store-session-cookies --accountProvider='twitter' --webapp='dHdpdHRlcg==' --webappModelSearchPath=. %u

the click review tool fails with:

 - desktop_Exec_webapp_args_required (webapp-twitter)
 should not specify --webappUrlPatterns, --webappModelSearchPath or --webapp= when running local application

It fails to detect that the situation is a valid one and instead "thinks" that we are running a local app.

Related branches

lp:~abreu-alexandre/click-reviewers-tools/fix-webapp-exec-field-code
Daniel Holbach (community): Approve
Diff: 81 lines (+43/-2)
2 files modified
clickreviews/cr_desktop.py (+6/-1)
clickreviews/tests/test_cr_desktop.py (+37/-1)
Alexandre Abreu (abreu-alexandre)
Changed in click-reviewers-tools:
assignee: nobody → Alexandre Abreu (abreu-alexandre)
status: New → In Progress
Alexandre Abreu (abreu-alexandre)
summary: - All webapps-core click review webapp fail
+ Failure to validate properly formatted webapp Exec lines
Daniel Holbach (dholbach)
Changed in click-reviewers-tools:
status: In Progress → Won't Fix
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.