Catfish

Close window with (standard) CTRL-Q

Bug #1447045 reported by ogghi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Catfish
Fix Released
Undecided
Sean Davis
Catfish 1.3.0

Bug Description

Would be nice to honor the standard (is it standard?)

Anyway pretty useful for keyboard lovers like me...

Revision history for this message
ogghi (david-) wrote :

Hi all, I'm a noob coding, but I might have added this: https://code.launchpad.net/~schmidt-f/catfish-search/catfish-search

Comments? Can you merge it to the trunk?

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

@ogghi: Thanks for the patch! For the future, please don't forget to file a merge-request (you can then link it to this bugreport) so that developers get notified. I'm not the python expert, so I'll leave it to Sean to decide whether to merge your patch as is.

Changed in catfish-search:
assignee: nobody → Sean Davis (bluesabre)
Revision history for this message
Sean Davis (bluesabre) wrote :

That is one way to do it. The way it's more commonly done in Gtk (being based in C) is to check the event for the Control Mask, as done here: https://bazaar.launchpad.net/~catfish-search/catfish-search/gtk316-csd/revision/372

    if event.get_state() & Gdk.ModifierType.CONTROL_MASK

Thanks for getting my eyes on this bug! Fixed in the next release.

Changed in catfish-search:
status: New → Fix Committed
Sean Davis (bluesabre)
Changed in catfish-search:
milestone: none → 1.3.0
Sean Davis (bluesabre)
Changed in catfish-search:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.