Not possible to exit history mode once in it

Bug #144962 reported by Nicholas Allen
4
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Fix Released
Undecided
Jasper Groenewegen

Bug Description

Once in history mode it is not possible to get out of it by turning off the history mode check box - the list still shows the old files as if still browsing with history mode on (even after a refresh).

Related branches

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 144962] Not possible to exit history mode once in it

  status incomplete

What do you mean by history mode?
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Changed in bzr-gtk:
status: New → Incomplete
Revision history for this message
Jasper Groenewegen (colbrac) wrote :

This bug concerns Olive. In the main window, on the right side of the adress bar you find [checkbox] History Mode [input] [Folder icon].
Usage: Click checkbox to active, enter revision number in input or select revision from list (pressing folder icon brings up list of revisions similar to Log window) and press Enter in input box (n.b. Numpad Enter doesn't work).
This changes the list of files and folders to the state of the given revision. Menubar buttons Diff, Commit, Pull, Push and Update are inactive (gray).

Right mouse button on a file gives 3 options 'View contents', 'Show differences' and 'Revert to this revision'. At least View contents and Show differences do not work. I didn't want to try Revert.

Once in this history mode there is no option to return to the normal mode. Unchecking the historymode box does nothing, changing the revision number in the history mode input box to the current number (with or without unchecking afterwards) keeps you in history mode. So as far as I can find there is no option anywhere in Olive to return to normal mode.

Revision history for this message
Jasper Groenewegen (colbrac) wrote :

Fix attached as patch. (Second patch ever so still be gentle! See other bug for first one :P)

On unchecking the checkbox, all that happens so far is that the input field and folder button are made insensitive (greyed out).
I added a call to OliveGtk.on_button_location_jump_clicked. This function reads the current location from the adress bar and refreshes the view + buttons accordingly.

Revision history for this message
Jasper Groenewegen (colbrac) wrote :

Fix attached to previous response

Changed in bzr-gtk:
assignee: nobody → colbrac
status: Incomplete → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-gtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.