bad assertions in WorkingTree4._add

Bug #145027 reported by Martin Pool
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Martin Pool

Bug Description

 affects bzr
 status confirmed
 importance medium

Originally reported by Blake Winton:

> @needs_tree_write_lock
> def _add(self, files, ids, kinds):
> """See MutableTree._add."""
> state = self.current_dirstate()
> for f, file_id, kind in zip(files, ids, kinds):
> f = f.strip('/')
> assert '//' not in f
> assert '..' not in f

Those assertions are wrong; it's fine to add a file whose name is eg
'a...t'. Also in any case they should not be raising AssertionError for
bad input data.

This is hard to reproduce from the command line but can be reproduced
from svn2bzr.

Revision history for this message
Martin Pool (mbp) wrote :

Patch posted.

Changed in bzr:
assignee: nobody → mbp
status: Confirmed → In Progress
Martin Pool (mbp)
Changed in bzr:
status: In Progress → Fix Committed
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 0.92
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.