Command for running CI testing in the autostart file should be grouped together

Bug #1450574 reported by Po-Hsu Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Next Generation Checkbox (CLI)
Fix Released
Medium
Po-Hsu Lin

Bug Description

For the recently merged branch [1], the command for checking systemd should be grouped together in the one-liner && || statment
e.g.
if you run the following command on Vivid:
$ pidof systemd && echo "A"; echo "B"; echo "C" || echo "D"; echo "E"; echo "F"
It will return
867
A
B
C
E
F

$ pidof no_such_pid && echo "A"; echo "B"; echo "C" || echo "D"; echo "E"; echo "F"
It will return
B
C
E
F

To fix this, it should be grouped like this:
$ pidof systemd && { echo A; echo B; } || { echo "C"; echo "D" ;}

The command sequence:
systemd-ci-notifier
checkbox sru
systemd-ci-mailer
upstart-ci-notifier
checkbox sru
upstart-ci-mailer

From the command sequence and the testing command above we can see it will try to run checkbox sru for systmed first,
therefore the only impact for this is that checkbox sru might be triggered twice, I will mark the importance for this as medium.

[1] https://code.launchpad.net/~cypressyew/checkbox/ci-systemd-compability/+merge/257851

Tags: bitesize

Related branches

Po-Hsu Lin (cypressyew)
Changed in checkbox-ng:
status: New → Confirmed
Po-Hsu Lin (cypressyew)
Changed in checkbox-ng:
status: Confirmed → In Progress
tags: added: bitesize
Po-Hsu Lin (cypressyew)
Changed in checkbox-ng:
status: In Progress → Fix Committed
Changed in checkbox-ng:
milestone: none → 0.20
Changed in checkbox-ng:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.