unwatch_elected_as_leader default implementation broken

Bug #1467907 reported by Kiall Mac Innes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tooz
Fix Released
Undecided
Kiall Mac Innes

Bug Description

The default unwatch_elected_as_leader implementation is broken, as it attempts to read and attribute that doesn't exist.

2015-06-23 11:29:02.962 CRITICAL designate [req-27141a65-bc11-4bea-9b02-809d9704ba88 - - - - -] AttributeError: 'KazooDriver' object has no attribute '_hooks'

2015-06-23 11:29:02.962 TRACE designate Traceback (most recent call last):
2015-06-23 11:29:02.962 TRACE designate File "/usr/local/bin/designate-pool-manager", line 10, in <module>
2015-06-23 11:29:02.962 TRACE designate sys.exit(main())
2015-06-23 11:29:02.962 TRACE designate File "/opt/stack/designate/designate/cmd/pool_manager.py", line 41, in main
2015-06-23 11:29:02.962 TRACE designate service.wait()
2015-06-23 11:29:02.962 TRACE designate File "/opt/stack/designate/designate/service.py", line 394, in wait
2015-06-23 11:29:02.962 TRACE designate _launcher.wait()
2015-06-23 11:29:02.962 TRACE designate File "/opt/stack/designate/designate/openstack/common/service.py", line 180, in wait
2015-06-23 11:29:02.962 TRACE designate status, signo = self._wait_for_exit_or_signal(ready_callback)
2015-06-23 11:29:02.962 TRACE designate File "/opt/stack/designate/designate/openstack/common/service.py", line 172, in _wait_for_exit_or_signal
2015-06-23 11:29:02.962 TRACE designate self.stop()
2015-06-23 11:29:02.962 TRACE designate File "/opt/stack/designate/designate/openstack/common/service.py", line 118, in stop
2015-06-23 11:29:02.962 TRACE designate self.services.stop()
2015-06-23 11:29:02.962 TRACE designate File "/opt/stack/designate/designate/openstack/common/service.py", line 465, in stop
2015-06-23 11:29:02.962 TRACE designate service.stop()
2015-06-23 11:29:02.962 TRACE designate File "/opt/stack/designate/designate/pool_manager/service.py", line 150, in stop
2015-06-23 11:29:02.962 TRACE designate self._stop_leader_election()
2015-06-23 11:29:02.962 TRACE designate File "/opt/stack/designate/designate/pool_manager/service.py", line 178, in _stop_leader_election
2015-06-23 11:29:02.962 TRACE designate self._pool_group_id, self._on_elected_leader)
2015-06-23 11:29:02.962 TRACE designate File "/usr/local/lib/python2.7/dist-packages/tooz/drivers/zookeeper.py", line 440, in unwatch_elected_as_leader
2015-06-23 11:29:02.962 TRACE designate group_id, callback)
2015-06-23 11:29:02.962 TRACE designate File "/usr/local/lib/python2.7/dist-packages/tooz/coordination.py", line 163, in unwatch_elected_as_leader
2015-06-23 11:29:02.962 TRACE designate if not self._hooks.elected_leader[group_id]:
2015-06-23 11:29:02.962 TRACE designate AttributeError: 'KazooDriver' object has no attribute '_hooks'
2015-06-23 11:29:02.962 TRACE designate

Kiall Mac Innes (kiall)
Changed in python-tooz:
assignee: nobody → Kiall Mac Innes (kiall)
Changed in python-tooz:
status: New → In Progress
Revision history for this message
Kiall Mac Innes (kiall) wrote :
Changed in python-tooz:
status: In Progress → Fix Committed
Changed in python-tooz:
milestone: none → 1.27.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.