endless loop in file xinitrc from ltsp

Bug #1468630 reported by alex
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LTSP5
Fix Released
Medium
Unassigned

Bug Description

ubuntux:~$ uname -a
Linux ubuntux 3.13.0-55-generic #94-Ubuntu SMP Thu Jun 18 00:28:41 UTC 2015 i686 i686 i686 GNU/Linux
ubuntux:~$ dpkg -l | grep ltsp
ii ltsp-docs 1.1-1 all LTSP Documentation
ii ltsp-server 5.5.1-1ubuntu2 all basic LTSP server environment
ii ltsp-server-standalone 5.5.1-1ubuntu2 all complete LTSP server environment
ii ltspfs 1.3-1 i386 Fuse based remote filesystem for LTSP thin clients

I use rdp session and i need only one attempt to login to remote server. I tried to set var "XINITRC_PROMPT_ON_EXIT" without results! i saw messagebox, but both buttons 'yes' and 'cancel' caused restarting of xfreerdp. I look at file "/opt/ltsp/i386/usr/share/ltsp/xinitrc":

> ldm-dialog --question "Would you like to start this session?" 2>/dev/null || true
> [ "$?" != 0 ] && BREAK_LOOP=1

I think '$?' at 2nd line is always '0' because of "|| true" at the end of 1st line.

PS: excuse me, i don't speek english well.

Revision history for this message
Vagrant Cascadian (vagrantc) wrote : Re: [Bug 1468630] [NEW] endless loop in file xinitrc from ltsp

On 2015-06-24, alex wrote:
> I use rdp session and i need only one attempt to login to remote server.
> I tried to set var "XINITRC_PROMPT_ON_EXIT" without results! i saw
> messagebox, but both buttons 'yes' and 'cancel' caused restarting of
> xfreerdp. I look at file "/opt/ltsp/i386/usr/share/ltsp/xinitrc":
>
>> ldm-dialog --question "Would you like to start this session?" 2>/dev/null || true
>> [ "$?" != 0 ] && BREAK_LOOP=1
>
> I think '$?' at 2nd line is always '0' because of "|| true" at the end
> of 1st line.

Thanks for reporting the issue!

I think the following patch should work:

diff --git a/client/share/ltsp/xinitrc b/client/share/ltsp/xinitrc
index 222f4a0..877040f 100755
--- a/client/share/ltsp/xinitrc
+++ b/client/share/ltsp/xinitrc
@@ -76,8 +76,7 @@ if boolean_is_true "$XINITRC_DAEMON"; then
             fi
         else
             if boolean_is_true "$XINITRC_PROMPT_ON_EXIT"; then
- ldm-dialog --question "Would you like to start this session?" 2>/dev/null || true
- [ "$?" != 0 ] && BREAK_LOOP=1
+ ldm-dialog --question "Would you like to start this session?" 2>/dev/null || BREAK_LOOP=1
             fi
         fi
     done

live well,
  vagrant

Revision history for this message
alex (alexfk) wrote :

will i see this patch in ubuntu packages?
i can edit one line manually of course, but i prefer OS packaging system for some reason ...

Revision history for this message
Vagrant Cascadian (vagrantc) wrote :
Changed in ltsp:
status: New → Fix Committed
Changed in ltsp:
importance: Undecided → Medium
Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

Fix released in LTSP 5.5.5.

Changed in ltsp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.