Designate

Incorrect length limit for TXT record data

Bug #1474012 reported by Kiall Mac Innes
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Medium
Federico Ceratto

Bug Description

Originally Reported by Florian Weimer.

TXT record data is presently validated incorrectly.

In DNS, TXT records are a non-empty list of strings, each string between 0 and 255 bytes long. The total length limit is somewhat less than 2**16, counting the characters of all strings and adding 1 for each element (irrespective of its length). The direct limit is 65535, but there are additional constraints in the DNS protocol which impose a smaller maximum length across all records for the same name/class/type tuple (so checking a single record is not possible in general).

Designate currently applies a strict length limit of 255, on the text format. This is insufficient for some SPF records. This is a functionality issue.

Tim Simmons (timsim)
Changed in designate:
status: New → Triaged
importance: Undecided → Medium
milestone: none → liberty-3
Kiall Mac Innes (kiall)
Changed in designate:
milestone: liberty-3 → liberty-rc1
Kiall Mac Innes (kiall)
Changed in designate:
milestone: liberty-rc1 → none
Hardik Parekh (hardik-parekh047)
Changed in designate:
assignee: nobody → hardik (hardik-parekh047)
Hardik Parekh (hardik-parekh047)
Changed in designate:
assignee: hardik (hardik-parekh047) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/251864

Changed in designate:
assignee: nobody → Federico Ceratto (federico-ceratto)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/251864
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=4cf00bfb7fed8da190361d74b86c783783e15d52
Submitter: Jenkins
Branch: master

commit 4cf00bfb7fed8da190361d74b86c783783e15d52
Author: Federico Ceratto <email address hidden>
Date: Tue Dec 1 13:25:58 2015 +0000

    Check TXT record length limit

    Change-Id: Ie423cb7037625d0cfaf4084bf8660790c45cd7c6
    Closes-Bug: #1474012

Changed in designate:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/264268

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b2

This issue was fixed in the openstack/designate 2.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (stable/liberty)

Change abandoned by Graham Hayes (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/264268
Reason: message

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Joshua Hesketh (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/264268
Reason: This branch (stable/liberty) is at End Of Life

Graham Hayes (grahamhayes)
Changed in designate:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.