It may be possible to request (un)pinning of CPUs not in the NUMA cpuset

Bug #1483613 reported by Alexis Lee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Alexis Lee

Bug Description

There's already a check to ensure pinned CPUs are unpinned and vice versa, but none to ensure the CPUs are in the known set. This could lead to an invalid system state and emergent bugs.

I noticed this via code inspection during Liberty. I don't know if it's possible to hit externally but it seems like a potential bug. John Garbutt encouraged me to open this for advertising.

Changed in nova:
assignee: nobody → Alexis Lee (alexisl)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/207040
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bcb3d5463573e4cde70c04458feac07e95ba011b
Submitter: Jenkins
Branch: master

commit bcb3d5463573e4cde70c04458feac07e95ba011b
Author: Alexis Lee <email address hidden>
Date: Wed Jul 29 14:26:43 2015 +0100

    Prevent (un)pinning unknown CPUs

    There's already a check to ensure pinned CPUs are unpinned and vice
    versa, but none to ensure the CPUs are in the known set. Add one.

    Closes-Bug: #1483613
    Change-Id: Ie3c55912fbbd0e2e7b6dd48ca3c110c2d92fc987

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-3 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.