DVR: create or update port by using notify specific host rather than fanout

Bug #1486795 reported by changzhi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Oleg Bondarev

Bug Description

Problem Description
================

Notify L3 agent when create or update port in _dvrscheduler_db.py.
Why use notify all L3 agent rather than specify L3 agent?

Proposed Change
===============

Notify specify L3 agent instead of fanout.

changzhi (changzhi)
Changed in neutron:
assignee: nobody → changzhi (changzhi)
summary: - DVR: create or update port by using notify specify host not fanout
+ DVR: create or update port by using notify specify host rather than
+ fanout
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214933

tags: added: l3-dvr-backlog
changzhi (changzhi)
summary: - DVR: create or update port by using notify specify host rather than
+ DVR: create or update port by using notify specific host rather than
fanout
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Zhi Chang (<email address hidden>) on branch: master
Review: https://review.openstack.org/214933

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/215457

Revision history for this message
lvmxh (shaohef) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/215457/

Changed in neutron:
assignee: changzhi (changzhi) → lvmxh (shaohef)
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/221209

Changed in neutron:
assignee: lvmxh (shaohef) → shihanzhang (shihanzhang)
status: New → In Progress
Revision history for this message
Carl Baldwin (carl-baldwin) wrote :

I tend to think this is an important scaling issue. I bumped it to high for that reason.

Changed in neutron:
importance: Medium → High
Revision history for this message
shihanzhang (shihanzhang) wrote :

hi Carl, can you help to review this patch https://review.openstack.org/221209

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/231555

Changed in neutron:
assignee: shihanzhang (shihanzhang) → Oleg Bondarev (obondarev)
Revision history for this message
Carl Baldwin (carl-baldwin) wrote :

Reviewers are very confused. Which of the three patches [1,2,3] should be considered for this? Will the authors come together and unify on a patch as co-authors at least? We need to abandon any patches that should not be considered and ideally arrive at one as the proposed fix.

[1] https://review.openstack.org/#/c/221209/
[2] https://review.openstack.org/#/c/231555/
[3] https://review.openstack.org/#/c/215457/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Carl Baldwin (<email address hidden>) on branch: master
Review: https://review.openstack.org/215457
Reason: We discussed in the L3 [1] meeting today that we should abandon this patch in favor of another one [2].

 [1] https://wiki.openstack.org/wiki/Meetings/Neutron-L3-Subteam
 [2] https://review.openstack.org/#/c/231555/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Carl Baldwin (<email address hidden>) on branch: master
Review: https://review.openstack.org/221209
Reason: We discussed in the L3 [1] meeting today that we should abandon this patch in favor of another one [2].

 [1] https://wiki.openstack.org/wiki/Meetings/Neutron-L3-Subteam
 [2] https://review.openstack.org/#/c/231555/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/231555
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d3b191984cfe2b24f16bd57c1b4bb8c555ee10e0
Submitter: Jenkins
Branch: master

commit d3b191984cfe2b24f16bd57c1b4bb8c555ee10e0
Author: Oleg Bondarev <email address hidden>
Date: Tue Oct 6 18:14:33 2015 +0300

    DVR: only notify needed agents on new VM port creation

    When a new VM which should be serviced by a DVR router appears
    on compute host, this router is scheduled to that host and
    notification is sent. Before the patch it was a broad notification
    while really we only need to notify agent on target host.
    This should decrease the load on neutron server at scale.

    Closes-Bug: #1486795
    Change-Id: Id48b6f6a71530c4f6092d2a07b2db1a5cd300c05

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/249864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/251439

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b1

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/kilo)

Change abandoned by Ed Bak (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/249864
Reason: Abandoning backport to Kilo.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/251439
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b49181abb64f6543d2325602779e0c3de96b202f
Submitter: Jenkins
Branch: stable/liberty

commit b49181abb64f6543d2325602779e0c3de96b202f
Author: Oleg Bondarev <email address hidden>
Date: Tue Oct 6 18:14:33 2015 +0300

    DVR: only notify needed agents on new VM port creation

    When a new VM which should be serviced by a DVR router appears
    on compute host, this router is scheduled to that host and
    notification is sent. Before the patch it was a broad notification
    while really we only need to notify agent on target host.
    This should decrease the load on neutron server at scale.

    Closes-Bug: #1486795
    (cherry picked from commit d3b191984cfe2b24f16bd57c1b4bb8c555ee10e0)

    Conflicts:

     neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py

    Change-Id: Id48b6f6a71530c4f6092d2a07b2db1a5cd300c05

tags: added: in-stable-liberty
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 7.0.2

This issue was fixed in the openstack/neutron 7.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.