has no "DisplayVersion" in uninstaller reg key

Bug #1488081 reported by TheBigBear
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Undecided
Unassigned

Bug Description

Because it has no "DisplayVersion" set in the uninstaller registry key, the windows add/remove cannot show a version number and it shows as blank.

This is a issue for any config management software that wants to know what version of this software is installed.

It is also easily fixed by adding the "AppVersion" value to the installer script file.

I will work on a patch and submit a merge request sometime soon. (hopefully still today - after I tested it here first and know that it works)

Related branches

TheBigBear (urs-rau-k)
description: updated
Revision history for this message
TheBigBear (urs-rau-k) wrote :

My changes are:
bzr diff -r-2..
=== modified file 'windows/OpenLP-2.0.iss.default'
--- windows/OpenLP-2.0.iss.default 2014-10-27 00:08:27 +0000
+++ windows/OpenLP-2.0.iss.default 2015-08-24 17:45:30 +0000
@@ -3,6 +3,7 @@

 #define AppName "OpenLP"
 #define AppVerName "OpenLP %(display_version)s"
+#define AppVersion "%(display_version)s"
 #define AppPublisher "OpenLP Developers"
 #define AppURL "http://openlp.org/"
 #define AppExeName "OpenLP.exe"
@@ -18,7 +19,8 @@
 ; (To generate a new GUID, click Tools | Generate GUID inside the IDE.)
 AppID={{AA7699FA-B2D2-43F4-8A70-D497D03C9485}
 AppName={#AppName}
-AppVerName={#AppVerName}
+AppVerName={cm:NameAndVersion,{#AppName},{#AppVersion}}
+AppVersion={#AppVersion}
 AppPublisher={#AppPublisher}
 AppPublisherURL={#AppURL}
 AppSupportURL={#AppURL}
@@ -32,6 +34,7 @@
 Compression=lzma/Max
 SolidCompression=true
 SetupIconFile=OpenLP.ico
+VersionInfoVersion={#AppVersion}
 WizardImageFile=WizImageBig.bmp
 WizardSmallImageFile=WizImageSmall.bmp
 ChangesAssociations=true

Revision history for this message
TheBigBear (urs-rau-k) wrote :

On a 64-bit windows you should get the DisplayVersion key under:
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall\{AA7699FA-B2D2-43F4-8A70-D497D03C9485}_is1]
"Inno Setup: Setup Version"="5.4.3 (a)"
"Inno Setup: App Path"="C:\\Program Files (x86)\\OpenLP"
"InstallLocation"="C:\\Program Files (x86)\\OpenLP\\"
"Inno Setup: Icon Group"="OpenLP 2.0.5"
"Inno Setup: User"="sysadmin.uk"
"Inno Setup: Selected Tasks"="desktopicon"
"Inno Setup: Deselected Tasks"=""
"Inno Setup: Language"="english"
"DisplayName"="OpenLP 2.0.5"
"DisplayVersion"="2.0.5" <------<-----------------------------------------------------------------------------------NEW 64-bit registry key ------------<-----<
"UninstallString"="\"C:\\Program Files (x86)\\OpenLP\\unins000.exe\""
"QuietUninstallString"="\"C:\\Program Files (x86)\\OpenLP\\unins000.exe\" /SILENT"
"Publisher"="OpenLP Developers"
"URLInfoAbout"="http://openlp.org/"
"HelpLink"="http://openlp.org/"
"URLUpdateInfo"="http://openlp.org/"
"NoModify"=dword:00000001
"NoRepair"=dword:00000001
"InstallDate"="20150824"
"EstimatedSize"=dword:000183b1

And on a 32-bit windows you should get the new DisplayVersion registry key under:
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{AA7699FA-B2D2-43F4-8A70-D497D03C9485}_is1]
"Inno Setup: Setup Version"="5.4.3 (a)"
"Inno Setup: App Path"="C:\\Program Files\\OpenLP"
"InstallLocation"="C:\\Program Files\\OpenLP\\"
"Inno Setup: Icon Group"="OpenLP 2.0.5"
"Inno Setup: User"="sysadmin.uk"
"Inno Setup: Selected Tasks"="desktopicon"
"Inno Setup: Deselected Tasks"=""
"Inno Setup: Language"="english"
"DisplayName"="OpenLP 2.0.5"
"DisplayVersion"="2.0.5" <-----<---------------------------------------------------------------------------------- NEW 32-bit registry key------------<-----<
"UninstallString"="\"C:\\Program Files\\OpenLP\\unins000.exe\""
"QuietUninstallString"="\"C:\\Program Files\\OpenLP\\unins000.exe\" /SILENT"
"Publisher"="OpenLP Developers"
"URLInfoAbout"="http://openlp.org/"
"HelpLink"="http://openlp.org/"
"URLUpdateInfo"="http://openlp.org/"
"NoModify"=dword:00000001
"NoRepair"=dword:00000001
"InstallDate"="20150825"
"EstimatedSize"=dword:000183b1

Revision history for this message
TheBigBear (urs-rau-k) wrote :

Just looked the Inno setup iss file over once more and find the following line odd:

AppID={{AA7699FA-B2D2-43F4-8A70-D497D03C9485}

I owudl have thought that line should be:
AppID={AA7699FA-B2D2-43F4-8A70-D497D03C9485}

i.e. without the doubled-up leading opening curly brace? But hey it used to work, so maybe that double curly brace was OK?

Revision history for this message
TheBigBear (urs-rau-k) wrote :

This patch adds the required lines to the Inno setup "iss" file, to cause the software version number to make it into the windows registry uninstall key for openLP.

Tim Bentley (trb143)
Changed in openlp:
milestone: none → 2.1.6
status: New → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.