diff creates inventory objects

Bug #149254 reported by Robert Collins
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Aaron Bentley

Bug Description

in diff.py, line 508, when content differs it delegates to inventory's
diff method. This adds several seconds to trivial diffs in moderate to
large trees.

This is kindof strange as the inventory cannot access content anyway,
and for trees whose inventory is not structured like our in memory one,
expensive.

We could make the thunked inventory object lazier, but really I think
that _maybe_diff_file_or_symlink should just have a case statement -
around (kinda, kindb) - and use the tree apis directly.

-Rob

 affects /products/bzr
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Martin Pool (mbp)
Changed in bzr:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Aaron Bentley (abentley) wrote :

Oooh, I hadn't noticed this bug. Yay for accidental fixes!

Changed in bzr:
assignee: nobody → aaron-bentley
status: Confirmed → Fix Committed
Aaron Bentley (abentley)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.