Evergreen

Duplicate Code in O::A::Cat::AssetCommon

Bug #1496977 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.9.1

Bug Description

Evergreen 2.9.0 and master as of Mon Sep 14 15:44:18 2015
OpenSRF: N/A
PostgreSQL: N/A

Using AssetCommon produces the below warning since e2f6cca0:

"my" variable $sc_entries masks earlier declaration in same scope at /usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm line 371.

This duplication also leads to loss of information inside the update_fleshed_copies routine, since the stat cat entries are retrieved, cleared, then retrieved again after being cleared. When the code later tries to use that information, it is gone.

It looks like two lines of code got duplicated in that commit.

A fix branch is forthcoming.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Fix is in user/dyrcona/lp1496977_assetcommon_dup_code on the working repo.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1496977_assetcommon_dup_code

tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Pushed to master and backported to rel_2_9.

Changed in evergreen:
milestone: none → 2.9.1
no longer affects: evergreen/2.9
Changed in evergreen:
status: New → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.