swift transaction id not logged for INFO level
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Undecided
|
Bryan Keller |
Bug Description
The SwiftLogFormatter will automatically add the trans_id from the logger's thread local to the message, except not if record.levelno != logging.INFO
I'm pretty sure the check originally was trying to *not* append transaction id to proxy access lines because they already had the transaction id - but I think now we *could* remove that check because it already does the record.txn_id not in msg check.
I think we *should* do it because:
a) transaction id's are great!
b) lots of middlewares log useful bits at INFO
c) not having transaction id's on every log lines associated with a request kills baby pandas
... as long as it doesn't mess up the defined log formats [1] I'm sure it'd be a good idea to remove that check and always add trans_id's form the thread local to log lines that don't already have it in them somewhere.
Changed in swift: | |
assignee: | nobody → Ruchi Parmar (ruchiparmar143) |
assignee: | Ruchi Parmar (ruchiparmar143) → nobody |
Changed in swift: | |
assignee: | nobody → janonymous (janonymous) |
Changed in swift: | |
assignee: | janonymous (janonymous) → Bryan Keller (kellerbr) |
Change abandoned by Tin Lam (<email address hidden>) on branch: master /review. openstack. org/285763
Review: https:/