Launchpad itself

Local variable referenced before assignment in logintoken GPG key validation

Bug #150591 reported by Diogo Matsubara
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jonathan Lange
Launchpad itself 10.03

Bug Description

The method _getGPGKey() in ValidateGPGKeyView have the following try/except:

        try:
            key = gpghandler.retrieveKey(fingerprint)
        except GPGKeyNotFoundError:
            self.addError(_(
                'Launchpad could not import this OpenPGP key, because %s. '
                'Check that you published it correctly in the global key ring '
                '(using <kbd>gpg --send-keys KEY</kbd>) and that you '
                'entered the fingerprint correctly (as produced by <kbd>'
                'gpg --fingerprint YOU</kdb>). Try later or '
                '<a href="%s/+editpgpkeys">cancel your request</a>.'
                % (key, person_url)))
            return None

When retrieveKey() raises a GPGKeyNotFoundError, the 'key' variable is unassigned causing OOPS-644C894 UnboundLocalError local variable 'key' referenced before assignment

The error message needs to be fixed as well. Currently it doesn't make much sense.

Related branches

lp:~jml/launchpad/expose-gpgkeys-bug-389872
Eleanor Berger (community): Approve
Diff: 1071 lines (+331/-148)
30 files modified
lib/canonical/launchpad/browser/logintoken.py (+31/-103)
lib/canonical/launchpad/database/logintoken.py (+70/-0)
lib/canonical/launchpad/doc/gpg-encryption.txt (+3/-3)
lib/canonical/launchpad/ftests/keys_for_tests.py (+1/-1)
lib/canonical/launchpad/interfaces/gpghandler.py (+38/-0)
lib/canonical/launchpad/interfaces/logintoken.py (+21/-0)
lib/canonical/launchpad/mail/incoming.py (+1/-1)
lib/canonical/launchpad/templates/logintoken-validatesignonlygpg.pt (+1/-1)
lib/canonical/launchpad/utilities/gpghandler.py (+12/-4)
lib/lp/archivepublisher/tests/archive-signing.txt (+1/-1)
lib/lp/registry/browser/configure.zcml (+7/-0)
lib/lp/registry/browser/person.py (+1/-1)
lib/lp/registry/browser/tests/gpg-views.txt (+3/-3)
lib/lp/registry/browser/tests/test_gpgkey.py (+30/-0)
lib/lp/registry/interfaces/gpg.py (+17/-5)
lib/lp/registry/interfaces/person.py (+12/-3)
lib/lp/registry/model/gpgkey.py (+18/-0)
lib/lp/registry/model/person.py (+3/-3)
lib/lp/registry/stories/webservice/xx-person.txt (+42/-0)
lib/lp/registry/templates/codeofconduct-list.pt (+1/-1)
lib/lp/registry/templates/person-editpgpkeys.pt (+6/-6)
lib/lp/registry/templates/person-portlet-contact-details.pt (+2/-2)
lib/lp/registry/templates/person-rdf-contents.pt (+1/-1)
lib/lp/registry/templates/signedcodeofconduct-add.pt (+1/-1)
lib/lp/soyuz/doc/archive.txt (+1/-1)
lib/lp/soyuz/doc/nascentupload.txt (+1/-1)
lib/lp/soyuz/stories/webservice/xx-archive.txt (+1/-1)
lib/lp/soyuz/tests/ppa.py (+2/-2)
lib/lp/soyuz/tests/test_packageupload.py (+1/-1)
lib/lp/soyuz/tests/test_publishing.py (+2/-2)
Revision history for this message
Diogo Matsubara (matsubara) wrote :

More recent occurance: OOPS-823EA59

Changed in launchpad:
status: New → Confirmed
Jonathan Lange (jml)
Changed in launchpad-foundations:
assignee: nobody → Jonathan Lange (jml)
importance: Undecided → High
milestone: none → 10.03
status: Confirmed → In Progress
Gary Poster (gary)
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Jonathan Lange (jml)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.