Ubuntu
ubuntu-system-settings package

system-settings may not be responding to system-image D-Bus signals

Bug #1509022 reported by Barry Warsaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Bill Filler
Canonical System Image 11 "OTA11"
Ubuntu system image
New
Undecided
Unassigned
ubuntu-system-settings (Ubuntu)
Fix Released
Medium
Jonas G. Drange

Bug Description

While testing system-image 3.0.2 for vivid overlay, using the test plan here https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-system-image (3.B - manual download for s-i 3), two problems were noticed.

First, when using `system-image-cli --set auto_download=0`, the system-settings panel didn't notice the change in the auto_download value. At first I though it might be missing the SettingsChanged D-Bus signal, but then I realized that the signal is not sent when using system-image-cli (only when using the normal D-Bus API). system-settings would have to poll for that value. I will open a bugtask for system-image but 1) I'm not sure it's possible to send the signal from the -cli; 2) it's an odd corner case anyway because generally only developers/testers are using system-image-cli.

Second, when I invoke the manual download through system-settings, I don't see any progress. It goes from 0% to prompting to install the update, after a short wait. Please verify that system-settings is responding to the UpdateProgress signal.

Tags: client updates

Related branches

lp:~jonas-drange/ubuntu-system-settings/lp1509022
Ken VanDine: Approve
PS Jenkins bot: Needs Fixing (continuous-integration)
Diff: 203 lines (+48/-40)
2 files modified
plugins/system-update/system_update.cpp (+39/-37)
plugins/system-update/system_update.h (+9/-3)
Revision history for this message
Barry Warsaw (barry) wrote :

Bug task for ubuntu-system-image involves research to see if the SettingsChanged D-Bus signal can be sent when a setting is changed via system-image-cli.

tags: added: client
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

Maybe system-image-cli should consume a dbus API from system-image-server? If not, in what other cases will the auto_download setting change remotely?

Apart from that, there's an actual bug in System Settings where if SI's dbus name changes (SI dies/restarts), we don't update our dbus proxy.

Changed in ubuntu-system-settings (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
tags: added: updates
Revision history for this message
Barry Warsaw (barry) wrote : Re: [Bug 1509022] Re: system-settings may not be responding to system-image D-Bus signals

On Apr 11, 2016, at 11:29 AM, Jonas G. Drange wrote:

>Maybe system-image-cli should consume a dbus API from system-image-
>server?

We used to do something just like this, as an option to si-cli, but it was
never used and caused problems for the test suite, so it eventually got ripped
out.

>If not, in what other cases will the auto_download setting change remotely?

It really shouldn't. It would be possible to tweak it directly via sqlite,
but that's crazy talk. And really, it most common cases it will only get
changed via D-Bus anyway.

>Apart from that, there's an actual bug in System Settings where if SI's
>dbus name changes (SI dies/restarts), we don't update our dbus proxy.

Don't forget that si-dbus is *designed* to self-exit after a timeout, by
default 10 minutes. It gets re-D-Bus activated on demand.

Bill Filler (bfiller)
Changed in canonical-devices-system-image:
milestone: none → backlog
assignee: nobody → Bill Filler (bfiller)
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: New → Confirmed
importance: Undecided → High
Jonas G. Drange (jonas-drange)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Jonas G. Drange (jonas-drange)
status: Confirmed → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Confirmed → Fix Committed
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
milestone: backlog → 11
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+16.10.20160523-0ubuntu1

---------------
ubuntu-system-settings (0.3+16.10.20160523-0ubuntu1) yakkety; urgency=medium

  * Catch connection errors asynchronously

 -- Ken VanDine <email address hidden> Mon, 23 May 2016 12:27:38 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.