Ubuntu
webbrowser-app package

[Pocket PC] fullscreen video isn't full screen

Bug #1511020 reported by Dubstar_04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
High
Lukáš Tinkl
webbrowser-app (Ubuntu)
Invalid
Medium
Unassigned

Bug Description

using the web browser on a pocket pc youtube videos don't go full screen. see attached image.

Related branches

lp:~lukas-kde/unity8/newWindowDecosAndPanel
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Daniel d'Andrada (community): Approve
Diff: 1462 lines (+422/-298)
26 files modified
qml/Components/ModeSwitchWarningDialog.qml (+1/-1)
qml/Components/PanelState/PanelState.qml (+3/-2)
qml/Components/WindowControlButtons.qml (+76/-31)
qml/Components/graphics/window-close.svg (+14/-0)
qml/Components/graphics/window-maximize.svg (+12/-0)
qml/Components/graphics/window-minimize.svg (+13/-0)
qml/Panel/Handle.qml (+2/-2)
qml/Panel/IndicatorItem.qml (+3/-0)
qml/Panel/Indicators/client/IndicatorsClient.qml (+1/-1)
qml/Panel/IndicatorsMenu.qml (+2/-2)
qml/Panel/MenuContent.qml (+1/-1)
qml/Panel/Panel.qml (+68/-80)
qml/Panel/PanelBackground.qml (+0/-21)
qml/Panel/PanelSeparatorLine.qml (+0/-25)
qml/Shell.qml (+1/-1)
qml/Stages/ApplicationWindow.qml (+2/-2)
qml/Stages/DecoratedWindow.qml (+18/-15)
qml/Stages/DesktopStage.qml (+73/-49)
qml/Stages/WindowDecoration.qml (+15/-10)
qml/Stages/WindowResizeArea.qml (+1/-1)
tests/qmltests/Panel/tst_Panel.qml (+45/-11)
tests/qmltests/Stages/tst_DesktopStage.qml (+68/-30)
tests/qmltests/Stages/tst_PhoneStage.qml (+1/-1)
tests/qmltests/Stages/tst_SurfaceContainer.qml (+1/-1)
tests/qmltests/Stages/tst_TabletStage.qml (+1/-1)
tests/qmltests/tst_Shell.qml (+0/-10)
Revision history for this message
Dubstar_04 (dubstar-04) wrote :
Revision history for this message
Olivier Tilloy (osomon) wrote :

Could it be that unity8 doesn’t honour fullscreen requests when in windowed mode?
Adding a unity8 task to find out.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Indeed, Olivier is right. This is not fully implemented in Windowed mode.

Changed in unity8 (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Lukáš Tinkl (lukas-kde)
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: New → Invalid
Lukáš Tinkl (lukas-kde)
Changed in unity8 (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

The webbrowser is somehow affected too: it should not display a text like "Swipe up to return from fullscreen" when running in windowed mode. Pressing Escape worked just fine for me in this case, the text needs to be adjusted.

Changed in webbrowser-app (Ubuntu):
status: Invalid → New
importance: Undecided → Medium
Revision history for this message
Olivier Tilloy (osomon) wrote :

This is another symptom of the same root cause as bug #1504084 : apps on unity8 run with qtubuntu, and there is code in the browser that assumes that qtubuntu == mobile (http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/Ubuntu/Web/plugin.cpp#L127). Until now this was a decent approximation, but not any longer.
I’ll mark this bug invalid for webbrowser-app to keep track of this general issue in only one bug. Thanks for pointing it out anyway!

Changed in webbrowser-app (Ubuntu):
status: New → Invalid
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

@osomon you might want to check my unity8 Platform detection plugin: http://bazaar.launchpad.net/~unity-team/unity8/trunk/view/head:/plugins/Unity/Platform/platform.h#L47

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.11+16.04.20151126-0ubuntu1

---------------
unity8 (8.11+16.04.20151126-0ubuntu1) xenial; urgency=medium

  [ Albert Astals Cid ]
  * Initialize the image to be transparent (LP: #1517128)
  * Update pot file
  * clazy improvements

  [ Andrea Cimitan ]
  * Shadows in launcher and dash using UbuntuShapeIcon

  [ CI Train Bot ]
  * Resync trunk.

  [ Daniel d'Andrada ]
  * Cursor plugin: add scroll wheel handling (LP: #1497091)
  * Cursor: Add more fallback names, a blank and custom cursor support
  * DesktopStage: swiping from right edge shows window spread
  * Don't stretch application surfaces when resizing (LP: #1497083)
  * Mouse has to push against edges to show launcher or apps spread (LP:
    #1510969)

  [ Josh Arenson ]
  * Don't let IntegratedLightDM muck with the username (LP: #1497081)

  [ Lukáš Tinkl ]
  * Implement new visuals for panel and window decorations (LP:
    #1493066, #1511020, #1497095)
  * Let systemd/logind handle the lid-close action
  * Make saving screenshots really async

  [ Michael Zanetti ]
  * detect touchpads too, not only mice (LP: #1518395)
  * move screenshots out of the Dash dir

 -- Michał Sawicz <email address hidden> Thu, 26 Nov 2015 13:52:00 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.