webclient: merge patrons missing

I'll add here my wish that the button only be visible for those with the MERGE_USERS perm.

I'll augment Chris' wish with my mine, that UI elements only get disabled and not disappear based on permissions.

Really, this is true of any element but I'll agree with both Chris and
Jason.

On Mon, Nov 23, 2015 at 10:23 AM, Jason Etheridge <email address hidden> wrote:

> I'll augment Chris' wish with my mine, that UI elements only get
> disabled and not disappear based on permissions.
>
> --
> You received this bug notification because you are subscribed to
> Evergreen.
> Matching subscriptions: evergreenbugs
> https://bugs.launchpad.net/bugs/1517596
>
> Title:
> webclient: merge patrons missing
>
> Status in Evergreen:
> New
>
> Bug description:
> The ability to merge two patrons via the client is missing from the
> web client.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1517596/+subscriptions
>

If an element is only disabled rather than hidden, then I request that it be visually apparent that it is disabled (ie, grayed out) and that it cannot be clicked on.

Merge patrons is a particular problem in the xul client because not only is it not grayed out, but it opens up the merge window and allows staff to get as far as selecting the lead account and trying to proceed with the merge before it gives an error. Having the option either grayed out or hidden would prevent confusion.

The merge patrons button is now available, but I'm getting a garbled Merge patrons interface when I use it on my test system. I'm not sure if it's just my test system or a problem in the code. I'll investigate further before closing this bug.

Confirmed what Kathy is seeing. Looks like the egPatronMerge service is referencing a nonexistent template: circ/share/t_merge_patrons.tt2

Looks like a file was missed by me in commit df82edde; fortunately, I have a copy. PR coming shortly.

A patch adding the missing template is available in the user/gmcharlt/lp1517596_merge_patrons branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1517596_merge_patrons

Works for me. Thanks Galen!