python-neutronclient

LBaaS v2 - LB update with admin-state-down fails

Bug #1523968 reported by Evgeny Fedoruk
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Undecided
Unassigned

Bug Description

Updating loadbalancer instance with admin-state-down fails

CLI Command:
neutron lbaas-loadbalancer-update --admin-state-down NFV_LB

Output:
Unrecognized attribute(s) 'admin_state_down'

Tags: lbaas
Evgeny Fedoruk (evgenyf)
Changed in neutron:
assignee: nobody → Evgeny Fedoruk (evgenyf)
Bo Chi (bochi-michael)
information type: Public → Public Security
information type: Public Security → Public
Revision history for this message
Bo Chi (bochi-michael) wrote :

Hi Evgeny,

I found in neutron that it's common that you should use `--admin-state-down` when creating resources, but should use `--admin-state-up false` when updating resources.
in neutronclient, the `--admin-state-down` will be converted to `--admin-state-up` in args2body().

do you know why there's such difference?

Revision history for this message
Reedip (reedip-banerjee-deactivatedaccount) wrote :

Generally admin-state-down is not an attribute of Update commands in neutron , as stated by Bo above.
Plus a similar bug has already been logged and is being worked upon.

https://bugs.launchpad.net/python-neutronclient/+bug/1515111

Revision history for this message
Evgeny Fedoruk (evgenyf) wrote :

Hi,
As it's now, admin-state-down is only possible on LB creation, it changes the default true value of admin-state-up to false.
On update, admin-state-up is possible but admin-state-down is not recognized.
If change https://review.openstack.org/#/c/255093/ will fix this issue, this bug should be canceled.

Revision history for this message
Reedip (reedip-banerjee-deactivatedaccount) wrote :

admin-state-down is not used during update, thats the policy in neutronclient.
However, https://review.openstack.org/#/c/255093/ will allow the user to Update the value of admin-state-up to True/False,and if the user does not pass it, the value would not be changed.
This approach is similar to the approaches of other CLIs in neutron

Revision history for this message
Reedip (reedip-banerjee-deactivatedaccount) wrote :

This is not a neutron issue, but a neutronclient side fix, as admin-state-down is not required during Update in any CLI

affects: neutron → python-neutronclient
OpenStack Infra (hudson-openstack)
Changed in python-neutronclient:
assignee: Evgeny Fedoruk (evgenyf) → Reedip (reedip-banerjee)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/255093
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=270da35b7bf0f0a36a8b0daed57e894c5d328a07
Submitter: Jenkins
Branch: master

commit 270da35b7bf0f0a36a8b0daed57e894c5d328a07
Author: reedip <email address hidden>
Date: Tue Jan 5 11:10:45 2016 +0900

    Update help information for lbaasv2 CLIs

    Help information for lbaasV2 Update CLIs lack several options
    ( Refer bug#1515111 ). This patch adds all the options which
    are missing in the "neutron lbaas-*-update " CLIs
    Also updated is the --http-method for HealthMonitor,
    making it case in-sensitive.
    This also adds update of --default-pool for L7 support.

    Change-Id: If859dc899efa92173c7a654e3f1481b35790faaa
    Closes-Bug: #1515111
    Closes-Bug: #1523968

Changed in python-neutronclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-neutronclient 5.0.0

This issue was fixed in the openstack/python-neutronclient 5.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.