adept_manager crashes when updating from Feisty to Gutsy and from Gutsy to Hardy

Bug #153016 reported by Giorgos Kylafas
4
Affects Status Importance Assigned to Milestone
adept (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: adept

I executed kdesu "adept_manager --version-upgrade", as described in
https://help.ubuntu.com/community/GutsyUpgrades#head-03dfe71741407e245a9fcd75bded428572061f53
but adept crashed after I hit the first "Next" (The text of the dialog window was "A new distribution version is available! Click next if you wish to upgrade now").

Gdb, valgrind and strace traces will follow...

Revision history for this message
Giorgos Kylafas (gekylafas) wrote :
Revision history for this message
Giorgos Kylafas (gekylafas) wrote :
Revision history for this message
Giorgos Kylafas (gekylafas) wrote :
Revision history for this message
Giorgos Kylafas (gekylafas) wrote :

Same thing happens with new adept-manager 2.1.2ubuntu26.2, only this time I cannot produce a backtrace because there is no '-dbgsym' package available for this version.

Revision history for this message
Marco Maini (maini10) wrote :

Thanks for your report. Please retry now after the official release. It's possible that this procedure doesn't working with unstable version.

Changed in adept:
assignee: nobody → maini10
status: New → Incomplete
Revision history for this message
Giorgos Kylafas (gekylafas) wrote :

Thanks for your attention. My last comment about adept-manager 2.1.2ubuntu26.2 was written after the official version had come out. To be absolutely sure, I gave it one more try today, but the (same as far as I can tell) problem remains.
What else can I do to help?

Revision history for this message
Marco Maini (maini10) wrote :

Sorry, I haven't checked the date of your last comment. Now this page https://help.ubuntu.com/community/GutsyUpgrades#head-3692aaaed415e3427f54ec62dd8659474516b525 describes an upgrade method, that should automatically offer upgrade wizard without the command "kdesu "adept_manager --version-upgrade". Please check if that procedure show automatically the wizard or not. Thanks.

Revision history for this message
Giorgos Kylafas (gekylafas) wrote :

I tried again, but it does not show the "version upgrade" button. I also removed my /etc/apt/preferences file, in case the pinnings there were not letting the upgrade take place, but it did not work. I then tried after having removed all third party repositories from sources.list (medibuntu, wine, kde-3.5.8), but still nothing. I then tried using not the greek mirror (gr.archive.ubuntu.com) but the main one, with no result yet again.

For the record, when I say "I tried" I mean that I run adept_manager both with and without the --version-upgrade option. The program crashed as usual in the first case and no automatic upgrade wizard was offered in the second.

I attach my present sources.list, in case there is something wrong with it. Is there any additional info about my setup that could help you?

Revision history for this message
Marco Maini (maini10) wrote :

Thanks. Information are complete for now. Report 153889 probably describe a similar issue.

Revision history for this message
Marco Maini (maini10) wrote :

Please test only the latest version (2.1.2ubuntu26.2) and without --version-upgrade option (this option is no longer required). Be sure that your system is updated. Then try to fetch updates in Adept. An arrow should appear in the right of toolbar with Upgrade Version label. Click on it and the wizard should start.
Thanks.

Revision history for this message
Giorgos Kylafas (gekylafas) wrote :

I did test with version 2.1.2.ubuntu26.2, even without the --version-upgrade option, as I mentioned in my previous message.
After failing in every test, I decided to skim though the adept code. I found nothing weird with it, the upgrade should have worked, but who knows what was going wrong. I would have run it through gdb to better follow the code path, but as I said, no -dbgsym package was available yet.

Anyway, I could not wait any longer (sorry :) and used the server way, i.e. "do-release-upgrade" which pretty much worked. I am now running Gutsy and probably cannot help you any further with this bug. You may close it if you like.

Revision history for this message
Marco Maini (maini10) wrote :

Thanks for your collaboration. Close this bug as you have suggested.

Changed in adept:
assignee: maini10 → nobody
status: Incomplete → Invalid
Revision history for this message
Giorgos Kylafas (gekylafas) wrote :

I had the same behaviour (crash after pressing "next") while trying to update to hardy, following the instructions in https://help.ubuntu.com/community/HardyUpgrades/Kubuntu.

This time I found the problem, though. :)

adept runs as root, and therefore it uses the settings in /root/.kde/share/config/kioslaverc when it tries to fetch any file from http://changelogs.ubuntu.com/ (upgradewizard.cpp:161). My root's kioslaverc had an invalid proxy, so no file was being retrieved which eventually was leading to the crash I was experiencing. Applying the attached patch helped me determine the problem.

As a side note, the file http://changelogs.ubuntu.com/meta-release-proposed does not currently contain an entry for hardy, only meta-release-development does.

Revision history for this message
Giorgos Kylafas (gekylafas) wrote :

Resetting the bug back to NEW as I found the reason it was happening for, and assigning it to the previous assignee to take notice of my findings.

Changed in adept:
assignee: nobody → maini10
status: Invalid → New
Revision history for this message
Giorgos Kylafas (gekylafas) wrote :

This patch avoids the crash I experience.

The crash occurs when:
a) --dist-upgrade-devel is given
and
b) the meta-release file cannot be downloaded.

Because of b), checkForDistUpgrade() fails. Despite this, the "2uparrow" button is displayed, because of a). If it is pressed, the upgrade wizard gets executed, it tries to fetch the release announcement file, a null pointer gets derefenced and adept crashes.

I do not consider this patch a 100% solution, because an error message about the _release announcement_ file is displayed while the problem is one step earlier: at the downloading of the meta-release file.

Furthermore, even if all internet connection issues are resolved by the user, re-pressing the "2uparrow" button will show an empty page 1 of the upgrade wizard, with an inactive "next" button, so the user is presented with a deadend.

The correct behavior, IMHO, would be to re-execute checkForDistUpgrade() at this point. As it is now, the only (and non-obvious) option is to close and restart adept.

Marco Maini (maini10)
Changed in adept:
assignee: maini10 → nobody
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

Adept 3.0 is much smarter about not crashing when downloads, etc fail.

Changed in adept:
importance: Undecided → Medium
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.