freeglut: FTBFS (amd64/gcc-4.0): invalid lvalue in assignment

Bug #15302 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
Debian
Fix Released
Unknown
Ubuntu
Fix Released
High
Matthias Klose

Bug Description

Automatically imported from Debian bug report #296242 http://bugs.debian.org/296242

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #296242 http://bugs.debian.org/296242

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Mon, 21 Feb 2005 12:11:53 +0100
From: Andreas Jochens <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: freeglut: FTBFS (amd64/gcc-4.0): invalid lvalue in assignment

Package: freeglut
Severity: normal
Tags: patch

When building 'freeglut' on amd64 with gcc-4.0,
I get the following error:

freeglut_callbacks.c:286: error: invalid lvalue in assignment
freeglut_callbacks.c: In function 'glutSpaceballRotateFunc':
freeglut_callbacks.c:294: error: invalid lvalue in assignment
freeglut_callbacks.c: In function 'glutSpaceballButtonFunc':
freeglut_callbacks.c:302: error: invalid lvalue in assignment
freeglut_callbacks.c: In function 'glutButtonBoxFunc':
freeglut_callbacks.c:310: error: invalid lvalue in assignment
freeglut_callbacks.c: In function 'glutDialsFunc':
freeglut_callbacks.c:318: error: invalid lvalue in assignment
freeglut_callbacks.c: In function 'glutTabletMotionFunc':
freeglut_callbacks.c:326: error: invalid lvalue in assignment
freeglut_callbacks.c: In function 'glutTabletButtonFunc':
freeglut_callbacks.c:334: error: invalid lvalue in assignment
make[3]: *** [libglut_la-freeglut_callbacks.lo] Error 1
make[3]: Leaving directory `/freeglut-2.2.0/src'

With the attached patch 'freeglut' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/freeglut-2.2.0/src/freeglut_internal.h ./src/freeglut_internal.h
--- ../tmp-orig/freeglut-2.2.0/src/freeglut_internal.h 2004-03-30 08:37:27.000000000 +0000
+++ ./src/freeglut_internal.h 2005-02-21 11:03:52.716154177 +0000
@@ -386,6 +386,9 @@
 #define FETCH_WCB(window,cbname) \
     ((FGCB ## cbname)((window).CallBacks[CB_ ## cbname]))

+#define FETCH_WCB_LVALUE(window,cbname) \
+ (((window).CallBacks[CB_ ## cbname]))
+
 /*
  * INVOKE_WCB() is used as:
  *
diff -urN ../tmp-orig/freeglut-2.2.0/src/freeglut_callbacks.c ./src/freeglut_callbacks.c
--- ../tmp-orig/freeglut-2.2.0/src/freeglut_callbacks.c 2004-03-30 08:37:27.000000000 +0000
+++ ./src/freeglut_callbacks.c 2005-02-21 11:04:03.621046165 +0000
@@ -41,7 +41,7 @@
 #define SET_CALLBACK(a) \
     if( fgStructure.Window == NULL ) \
         return; \
- FETCH_WCB( ( *( fgStructure.Window ) ), a ) = callback;
+ FETCH_WCB_LVALUE( ( *( fgStructure.Window ) ), a ) = callback;

 /*
  * Sets the Display callback for the current window
diff -urN ../tmp-orig/freeglut-2.2.0/src/freeglut_structure.c ./src/freeglut_structure.c
--- ../tmp-orig/freeglut-2.2.0/src/freeglut_structure.c 2004-03-30 08:37:27.000000000 +0000
+++ ./src/freeglut_structure.c 2005-02-21 11:04:48.272414660 +0000
@@ -209,7 +209,7 @@
     {
         void *destroy = FETCH_WCB( *window, Destroy );
         fgClearCallBacks( window );
- FETCH_WCB( *window, Destroy ) = destroy;
+ FETCH_WCB_LVALUE( *window, Destroy ) = destroy;
     }
 }

Revision history for this message
Matthias Klose (doko) wrote :

fixed in freeglut_2.2.0-8ubuntu1

Revision history for this message
In , Aurelien Jarno (aurelien-aurel32) wrote : Upgrading gcc-4.0 bugs to RC
Download full text (8.3 KiB)

severity 284166 serious
severity 284201 serious
severity 284741 serious
severity 284770 serious
severity 284865 serious
severity 284872 serious
severity 284885 serious
severity 285080 serious
severity 285086 serious
severity 285090 serious
severity 285095 serious
severity 285100 serious
severity 285469 serious
severity 285473 serious
severity 285475 serious
severity 285481 serious
severity 285484 serious
severity 285528 serious
severity 285533 serious
severity 285539 serious
severity 285542 serious
severity 285546 serious
severity 285577 serious
severity 285593 serious
severity 285605 serious
severity 285613 serious
severity 285624 serious
severity 285626 serious
severity 285628 serious
severity 285635 serious
severity 285646 serious
severity 285693 serious
severity 285697 serious
severity 285813 serious
severity 285918 serious
severity 285935 serious
severity 285936 serious
severity 286146 serious
severity 286428 serious
severity 286446 serious
severity 286470 serious
severity 286471 serious
severity 286474 serious
severity 286475 serious
severity 286478 serious
severity 286483 serious
severity 286487 serious
severity 286492 serious
severity 286495 serious
severity 286496 serious
severity 286503 serious
severity 286732 serious
severity 286734 serious
severity 286783 serious
severity 286784 serious
severity 286822 serious
severity 286836 serious
severity 286867 serious
severity 286872 serious
severity 286876 serious
severity 286911 serious
severity 286919 serious
severity 286925 serious
severity 286927 serious
severity 286929 serious
severity 286959 serious
severity 286964 serious
severity 287066 serious
severity 287244 serious
severity 287374 serious
severity 287376 serious
severity 287383 serious
severity 287394 serious
severity 287422 serious
severity 287449 serious
severity 287451 serious
severity 287463 serious
severity 287493 serious
severity 287494 serious
severity 287628 serious
severity 287629 serious
severity 287630 serious
severity 287633 serious
severity 287635 serious
severity 287639 serious
severity 287648 serious
severity 287660 serious
severity 287677 serious
severity 287679 serious
severity 287749 serious
severity 287843 serious
severity 287846 serious
severity 287850 serious
severity 287853 serious
severity 287854 serious
severity 287882 serious
severity 287884 serious
severity 287885 serious
severity 287886 serious
severity 287891 serious
severity 287901 serious
severity 287902 serious
severity 287907 serious
severity 287918 serious
severity 287922 serious
severity 287923 serious
severity 287924 serious
severity 287960 serious
severity 288178 serious
severity 288190 serious
severity 288305 serious
severity 288361 serious
severity 288437 serious
severity 288439 serious
severity 288441 serious
severity 288459 serious
severity 288536 serious
severity 288578 serious
severity 288586 serious
severity 288599 serious
severity 288648 serious
severity 288660 serious
severity 288697 serious
severity 288702 serious
severity 288726 serious
severity 288794 serious
severity 288832 serious
severity 288834 serious
severity 288925 serious
severity 288933 serious
severity 288966 serious
severity 288981 serious
severity 288989 serious
severity...

Read more...

Revision history for this message
In , Paul Brook (paul-codesourcery) wrote : freeglut: Also FTBFS on i386

Package: freeglut
Followup-For: Bug #296242

This package now FTBFS on i386 with the same error. Alternative patch
below.

diff -u clean/freeglut_callbacks.c ./freeglut_callbacks.c
--- clean/freeglut_callbacks.c 2004-03-30 09:37:27.000000000 +0100
+++ ./freeglut_callbacks.c 2005-07-16 11:30:17.000000000 +0100
@@ -41,7 +41,7 @@
 #define SET_CALLBACK(a) \
     if( fgStructure.Window == NULL ) \
         return; \
- FETCH_WCB( ( *( fgStructure.Window ) ), a ) = callback;
+ SET_WCB( ( *( fgStructure.Window ) ), a, callback);

 /*
  * Sets the Display callback for the current window
diff -u clean/freeglut_internal.h ./freeglut_internal.h
--- clean/freeglut_internal.h 2004-03-30 09:37:27.000000000 +0100
+++ ./freeglut_internal.h 2005-07-16 11:29:52.000000000 +0100
@@ -373,6 +373,17 @@

 /*
+ * SET_WCB() is used as:
+ *
+ * SET_WCB( window, Visibility, val);
+ *
+ * ...where {window} is the freeglut window to set the callback on,
+ * {Visibility} is the window-specific callback to fetch.
+ */
+#define SET_WCB(window,cbname,val) \
+ ((window).CallBacks[CB_ ## cbname]) = (void *)val
+
+/*
  * FETCH_WCB() is used as:
  *
  * FETCH_WCB( window, Visibility );
diff -u clean/freeglut_structure.c ./freeglut_structure.c
--- clean/freeglut_structure.c 2004-03-30 09:37:27.000000000 +0100
+++ ./freeglut_structure.c 2005-07-16 11:30:31.000000000 +0100
@@ -209,7 +209,7 @@
     {
         void *destroy = FETCH_WCB( *window, Destroy );
         fgClearCallBacks( window );
- FETCH_WCB( *window, Destroy ) = destroy;
+ SET_WCB( *window, Destroy, destroy);
     }
 }

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12.2-f
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Revision history for this message
In , Roger Leigh (rleigh) wrote : Fixed in NMU of freeglut 2.2.0-8.1

tag 296242 + fixed

quit

This message was generated automatically in response to a
non-maintainer upload. The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 19 Jul 2005 23:15:25 +0100
Source: freeglut
Binary: freeglut3-dbg freeglut3-dev freeglut3
Architecture: source powerpc
Version: 2.2.0-8.1
Distribution: unstable
Urgency: low
Maintainer: Jamie Wilkinson <email address hidden>
Changed-By: Roger Leigh <email address hidden>
Description:
 freeglut3 - OpenGL Utility Toolkit
 freeglut3-dbg - OpenGL Utility Toolkit debugging information
 freeglut3-dev - OpenGL Utility Toolkit development files
Closes: 296242
Changes:
 freeglut (2.2.0-8.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Apply patch from Paul Brook to fix build failure with GCC 4.0
     (Closes: #296242).
Files:
 07ee1c6928724b630d8c3e4d366501dc 714 graphics optional freeglut_2.2.0-8.1.dsc
 e3ce5cde7f0a4d02ecd94f30b19293c0 14187 graphics optional freeglut_2.2.0-8.1.diff.gz
 229743b2c08719a8ba2460d6b4d1bd61 78326 libs optional freeglut3_2.2.0-8.1_powerpc.deb
 8b611f0813fd01ed04bcbd3b8ecc9973 149726 libdevel optional freeglut3-dev_2.2.0-8.1_powerpc.deb
 cb146c060ad99335ef825b28736e7e90 113120 libdevel optional freeglut3-dbg_2.2.0-8.1_powerpc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFC3X/kVcFcaSW/uEgRAgX2AJ9O3pnu/hfBCsyQDwOiKJNAn7VGZwCg8PJt
SH+pS7eUN5YlmGCIXpdubnc=
=oMi2
-----END PGP SIGNATURE-----

Revision history for this message
In , Jamie Wilkinson (jaq-spacepants) wrote :

I was holding off an upload because of the libGLU c++ transition. Did you
take that into account?

Also, last I checked, contacting the maintainer was a required step in an
NMU. When were you planning on letting me know your intentions?

This one time, at band camp, Roger Leigh wrote:
>tag 296242 + fixed
>
>quit
>
>This message was generated automatically in response to a
>non-maintainer upload. The .changes file follows.
>
>Format: 1.7
>Date: Tue, 19 Jul 2005 23:15:25 +0100
>Source: freeglut
>Binary: freeglut3-dbg freeglut3-dev freeglut3
>Architecture: source powerpc
>Version: 2.2.0-8.1
>Distribution: unstable
>Urgency: low
>Maintainer: Jamie Wilkinson <email address hidden>
>Changed-By: Roger Leigh <email address hidden>
>Description:
> freeglut3 - OpenGL Utility Toolkit
> freeglut3-dbg - OpenGL Utility Toolkit debugging information
> freeglut3-dev - OpenGL Utility Toolkit development files
>Closes: 296242
>Changes:
> freeglut (2.2.0-8.1) unstable; urgency=low
> .
> * Non-maintainer upload.
> * Apply patch from Paul Brook to fix build failure with GCC 4.0
> (Closes: #296242).
>Files:
> 07ee1c6928724b630d8c3e4d366501dc 714 graphics optional freeglut_2.2.0-8.1.dsc
> e3ce5cde7f0a4d02ecd94f30b19293c0 14187 graphics optional freeglut_2.2.0-8.1.diff.gz
> 229743b2c08719a8ba2460d6b4d1bd61 78326 libs optional freeglut3_2.2.0-8.1_powerpc.deb
> 8b611f0813fd01ed04bcbd3b8ecc9973 149726 libdevel optional freeglut3-dev_2.2.0-8.1_powerpc.deb
> cb146c060ad99335ef825b28736e7e90 113120 libdevel optional freeglut3-dbg_2.2.0-8.1_powerpc.deb
>

Revision history for this message
In , Roger Leigh (rleigh) wrote :

On Wed, Jul 20, 2005 at 09:53:01AM +1000, Jamie Wilkinson wrote:
> I was holding off an upload because of the libGLU c++ transition. Did you
> take that into account?

The direct dependencies have not changed, so there should be no problems.
AFAICT, xlibmesa-gl, xlibmesa-glu and libglut3 have no external ABI
changes.

xlibmesa-gl is still the old version on arm,m68k,mips,mipsel,sparc, so
may not currently build on those platforms (I'm afraid I didn't spot
that), but they should just be put into dep-wait for a few days. Since
it's now built on 7/9 arches, this doesn't appear to be problematic.

> Also, last I checked, contacting the maintainer was a required step in an
> NMU. When were you planning on letting me know your intentions?

This package was one of a list of packages I was asked to fix by the
RM. 0-day NMUs are also OK for GCC 4.0 FTBFS bugs, apparently.

I do normally contact people, but due to the above, and the lack of
any response to the original bug report, I did not. If you had put
a note on the bug report to let people know that you were taking
care of it, I would have left it. As it was, it looked like just
another of the ~400 etch RC FTBFS bugs which had not been fixed by
their (MIA) maintainer.

(http://bts.turmzimmer.net/details.php?ignore=sid&ignpending=on&ignmerged=on&igncontrib=on&ignnonfree=on&new=100&refresh=900)

Regards,
Roger

--
Roger Leigh

                Printing on GNU/Linux? http://gimp-print.sourceforge.net/
                GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.

Revision history for this message
In , Steve Langasek (vorlon) wrote : Re: Bug#296242: Fixed in NMU of freeglut 2.2.0-8.1

On Wed, Jul 20, 2005 at 10:34:14AM +0100, Roger Leigh wrote:
> On Wed, Jul 20, 2005 at 09:53:01AM +1000, Jamie Wilkinson wrote:
> > I was holding off an upload because of the libGLU c++ transition. Did you
> > take that into account?

> The direct dependencies have not changed, so there should be no problems.
> AFAICT, xlibmesa-gl, xlibmesa-glu and libglut3 have no external ABI
> changes.

> xlibmesa-gl is still the old version on arm,m68k,mips,mipsel,sparc, so
> may not currently build on those platforms (I'm afraid I didn't spot
> that), but they should just be put into dep-wait for a few days. Since
> it's now built on 7/9 arches, this doesn't appear to be problematic.

> > Also, last I checked, contacting the maintainer was a required step in an
> > NMU. When were you planning on letting me know your intentions?

> This package was one of a list of packages I was asked to fix by the
> RM. 0-day NMUs are also OK for GCC 4.0 FTBFS bugs, apparently.

Nothing I say trumps the requirement to inform maintainers about the changes
you're making to their packages and to make certain for yourself that the
NMU is warranted and correct. Please read this as implicit in any
suggestions I make regarding NMU candidates.

> I do normally contact people, but due to the above, and the lack of
> any response to the original bug report, I did not. If you had put
> a note on the bug report to let people know that you were taking
> care of it, I would have left it. As it was, it looked like just
> another of the ~400 etch RC FTBFS bugs which had not been fixed by
> their (MIA) maintainer.

In this case, there will be a need to update the build-dependencies of
freeglut shortly; there are no ABI transitions taking place for libGLU
(though it was reasonable for Jamie to wait, in light of the confusion
surrounding this question), but the xlibmesa-glu-dev package *is* going away
once the xfree86 source package is phased out in favor of xorg-x11, and
packages will need to build-depend on libglu1-xorg-dev instead.

The net impact is relatively minor, but IMHO it would have been better to
wait for libglu1-xorg-dev to be available on all architectures, and address
both issues at once. In that case, it seems you could have simply let Jamie
do the upload himself. :) Sorry for not being more clear.

--
Steve Langasek
postmodern programmer

Revision history for this message
In , Roger Leigh (rleigh-whinlatter) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Steve Langasek <email address hidden> writes:

> On Wed, Jul 20, 2005 at 10:34:14AM +0100, Roger Leigh wrote:
>> On Wed, Jul 20, 2005 at 09:53:01AM +1000, Jamie Wilkinson wrote:

>> > Also, last I checked, contacting the maintainer was a required step in an
>> > NMU. When were you planning on letting me know your intentions?
>
>> This package was one of a list of packages I was asked to fix by the
>> RM. 0-day NMUs are also OK for GCC 4.0 FTBFS bugs, apparently.
>
> Nothing I say trumps the requirement to inform maintainers about the changes
> you're making to their packages and to make certain for yourself that the
> NMU is warranted and correct. Please read this as implicit in any
> suggestions I make regarding NMU candidates.

Please both accept my apologies. I'll make sure to do that in the
future.

Regards,
Roger

- --
Roger Leigh
                Printing on GNU/Linux? http://gimp-print.sourceforge.net/
                Debian GNU/Linux http://www.debian.org/
                GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFC3r1zVcFcaSW/uEgRAnn+AJ9k+L2uQXmFG9+D8BSJ+Z17ueDzvgCg2ixE
OXYEg8xUYEurJoeFvWC4dlQ=
=XiOm
-----END PGP SIGNATURE-----

Revision history for this message
In , Jamie Wilkinson (jaq-spacepants) wrote :

This one time, at band camp, Roger Leigh wrote:
>Steve Langasek <email address hidden> writes:
>
>> On Wed, Jul 20, 2005 at 10:34:14AM +0100, Roger Leigh wrote:
>>> On Wed, Jul 20, 2005 at 09:53:01AM +1000, Jamie Wilkinson wrote:
>
>>> > Also, last I checked, contacting the maintainer was a required step in an
>>> > NMU. When were you planning on letting me know your intentions?
>>
>>> This package was one of a list of packages I was asked to fix by the
>>> RM. 0-day NMUs are also OK for GCC 4.0 FTBFS bugs, apparently.
>>
>> Nothing I say trumps the requirement to inform maintainers about the changes
>> you're making to their packages and to make certain for yourself that the
>> NMU is warranted and correct. Please read this as implicit in any
>> suggestions I make regarding NMU candidates.
>
>Please both accept my apologies. I'll make sure to do that in the
>future.

Ok, no problem. I was merely surprised to find an upload without any
mention in the bug report about the intention, and I had not had any coffee.

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (8.5 KiB)

Message-ID: <email address hidden>
Date: Fri, 15 Jul 2005 11:15:32 +0200
From: Aurelien Jarno <email address hidden>
To: <email address hidden>
Subject: Upgrading gcc-4.0 bugs to RC

severity 284166 serious
severity 284201 serious
severity 284741 serious
severity 284770 serious
severity 284865 serious
severity 284872 serious
severity 284885 serious
severity 285080 serious
severity 285086 serious
severity 285090 serious
severity 285095 serious
severity 285100 serious
severity 285469 serious
severity 285473 serious
severity 285475 serious
severity 285481 serious
severity 285484 serious
severity 285528 serious
severity 285533 serious
severity 285539 serious
severity 285542 serious
severity 285546 serious
severity 285577 serious
severity 285593 serious
severity 285605 serious
severity 285613 serious
severity 285624 serious
severity 285626 serious
severity 285628 serious
severity 285635 serious
severity 285646 serious
severity 285693 serious
severity 285697 serious
severity 285813 serious
severity 285918 serious
severity 285935 serious
severity 285936 serious
severity 286146 serious
severity 286428 serious
severity 286446 serious
severity 286470 serious
severity 286471 serious
severity 286474 serious
severity 286475 serious
severity 286478 serious
severity 286483 serious
severity 286487 serious
severity 286492 serious
severity 286495 serious
severity 286496 serious
severity 286503 serious
severity 286732 serious
severity 286734 serious
severity 286783 serious
severity 286784 serious
severity 286822 serious
severity 286836 serious
severity 286867 serious
severity 286872 serious
severity 286876 serious
severity 286911 serious
severity 286919 serious
severity 286925 serious
severity 286927 serious
severity 286929 serious
severity 286959 serious
severity 286964 serious
severity 287066 serious
severity 287244 serious
severity 287374 serious
severity 287376 serious
severity 287383 serious
severity 287394 serious
severity 287422 serious
severity 287449 serious
severity 287451 serious
severity 287463 serious
severity 287493 serious
severity 287494 serious
severity 287628 serious
severity 287629 serious
severity 287630 serious
severity 287633 serious
severity 287635 serious
severity 287639 serious
severity 287648 serious
severity 287660 serious
severity 287677 serious
severity 287679 serious
severity 287749 serious
severity 287843 serious
severity 287846 serious
severity 287850 serious
severity 287853 serious
severity 287854 serious
severity 287882 serious
severity 287884 serious
severity 287885 serious
severity 287886 serious
severity 287891 serious
severity 287901 serious
severity 287902 serious
severity 287907 serious
severity 287918 serious
severity 287922 serious
severity 287923 serious
severity 287924 serious
severity 287960 serious
severity 288178 serious
severity 288190 serious
severity 288305 serious
severity 288361 serious
severity 288437 serious
severity 288439 serious
severity 288441 serious
severity 288459 serious
severity 288536 serious
severity 288578 serious
severity 288586 serious
severity 288599 serious
severity 288648 serious
severity 288660 serious
severity 288697 serious
severity 288702 serious
severity 288726 serio...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Sat, 16 Jul 2005 11:38:13 +0100
From: Paul Brook <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: freeglut: Also FTBFS on i386

Package: freeglut
Followup-For: Bug #296242

This package now FTBFS on i386 with the same error. Alternative patch
below.

diff -u clean/freeglut_callbacks.c ./freeglut_callbacks.c
--- clean/freeglut_callbacks.c 2004-03-30 09:37:27.000000000 +0100
+++ ./freeglut_callbacks.c 2005-07-16 11:30:17.000000000 +0100
@@ -41,7 +41,7 @@
 #define SET_CALLBACK(a) \
     if( fgStructure.Window == NULL ) \
         return; \
- FETCH_WCB( ( *( fgStructure.Window ) ), a ) = callback;
+ SET_WCB( ( *( fgStructure.Window ) ), a, callback);

 /*
  * Sets the Display callback for the current window
diff -u clean/freeglut_internal.h ./freeglut_internal.h
--- clean/freeglut_internal.h 2004-03-30 09:37:27.000000000 +0100
+++ ./freeglut_internal.h 2005-07-16 11:29:52.000000000 +0100
@@ -373,6 +373,17 @@

 /*
+ * SET_WCB() is used as:
+ *
+ * SET_WCB( window, Visibility, val);
+ *
+ * ...where {window} is the freeglut window to set the callback on,
+ * {Visibility} is the window-specific callback to fetch.
+ */
+#define SET_WCB(window,cbname,val) \
+ ((window).CallBacks[CB_ ## cbname]) = (void *)val
+
+/*
  * FETCH_WCB() is used as:
  *
  * FETCH_WCB( window, Visibility );
diff -u clean/freeglut_structure.c ./freeglut_structure.c
--- clean/freeglut_structure.c 2004-03-30 09:37:27.000000000 +0100
+++ ./freeglut_structure.c 2005-07-16 11:30:31.000000000 +0100
@@ -209,7 +209,7 @@
     {
         void *destroy = FETCH_WCB( *window, Destroy );
         fgClearCallBacks( window );
- FETCH_WCB( *window, Destroy ) = destroy;
+ SET_WCB( *window, Destroy, destroy);
     }
 }

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12.2-f
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Tue, 19 Jul 2005 18:47:20 -0400
From: Roger Leigh <email address hidden>
To: <email address hidden>
Cc: Roger Leigh <email address hidden>, Jamie Wilkinson <email address hidden>
Subject: Fixed in NMU of freeglut 2.2.0-8.1

tag 296242 + fixed

quit

This message was generated automatically in response to a
non-maintainer upload. The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 19 Jul 2005 23:15:25 +0100
Source: freeglut
Binary: freeglut3-dbg freeglut3-dev freeglut3
Architecture: source powerpc
Version: 2.2.0-8.1
Distribution: unstable
Urgency: low
Maintainer: Jamie Wilkinson <email address hidden>
Changed-By: Roger Leigh <email address hidden>
Description:
 freeglut3 - OpenGL Utility Toolkit
 freeglut3-dbg - OpenGL Utility Toolkit debugging information
 freeglut3-dev - OpenGL Utility Toolkit development files
Closes: 296242
Changes:
 freeglut (2.2.0-8.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Apply patch from Paul Brook to fix build failure with GCC 4.0
     (Closes: #296242).
Files:
 07ee1c6928724b630d8c3e4d366501dc 714 graphics optional freeglut_2.2.0-8.1.dsc
 e3ce5cde7f0a4d02ecd94f30b19293c0 14187 graphics optional freeglut_2.2.0-8.1.diff.gz
 229743b2c08719a8ba2460d6b4d1bd61 78326 libs optional freeglut3_2.2.0-8.1_powerpc.deb
 8b611f0813fd01ed04bcbd3b8ecc9973 149726 libdevel optional freeglut3-dev_2.2.0-8.1_powerpc.deb
 cb146c060ad99335ef825b28736e7e90 113120 libdevel optional freeglut3-dbg_2.2.0-8.1_powerpc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFC3X/kVcFcaSW/uEgRAgX2AJ9O3pnu/hfBCsyQDwOiKJNAn7VGZwCg8PJt
SH+pS7eUN5YlmGCIXpdubnc=
=oMi2
-----END PGP SIGNATURE-----

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 20 Jul 2005 09:53:01 +1000
From: Jamie Wilkinson <email address hidden>
To: Roger Leigh <email address hidden>
Cc: <email address hidden>
Subject: Re: Fixed in NMU of freeglut 2.2.0-8.1

I was holding off an upload because of the libGLU c++ transition. Did you
take that into account?

Also, last I checked, contacting the maintainer was a required step in an
NMU. When were you planning on letting me know your intentions?

This one time, at band camp, Roger Leigh wrote:
>tag 296242 + fixed
>
>quit
>
>This message was generated automatically in response to a
>non-maintainer upload. The .changes file follows.
>
>Format: 1.7
>Date: Tue, 19 Jul 2005 23:15:25 +0100
>Source: freeglut
>Binary: freeglut3-dbg freeglut3-dev freeglut3
>Architecture: source powerpc
>Version: 2.2.0-8.1
>Distribution: unstable
>Urgency: low
>Maintainer: Jamie Wilkinson <email address hidden>
>Changed-By: Roger Leigh <email address hidden>
>Description:
> freeglut3 - OpenGL Utility Toolkit
> freeglut3-dbg - OpenGL Utility Toolkit debugging information
> freeglut3-dev - OpenGL Utility Toolkit development files
>Closes: 296242
>Changes:
> freeglut (2.2.0-8.1) unstable; urgency=low
> .
> * Non-maintainer upload.
> * Apply patch from Paul Brook to fix build failure with GCC 4.0
> (Closes: #296242).
>Files:
> 07ee1c6928724b630d8c3e4d366501dc 714 graphics optional freeglut_2.2.0-8.1.dsc
> e3ce5cde7f0a4d02ecd94f30b19293c0 14187 graphics optional freeglut_2.2.0-8.1.diff.gz
> 229743b2c08719a8ba2460d6b4d1bd61 78326 libs optional freeglut3_2.2.0-8.1_powerpc.deb
> 8b611f0813fd01ed04bcbd3b8ecc9973 149726 libdevel optional freeglut3-dev_2.2.0-8.1_powerpc.deb
> cb146c060ad99335ef825b28736e7e90 113120 libdevel optional freeglut3-dbg_2.2.0-8.1_powerpc.deb
>

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 20 Jul 2005 10:34:14 +0100
From: Roger Leigh <email address hidden>
To: Jamie Wilkinson <email address hidden>
Cc: <email address hidden>
Subject: Re: Fixed in NMU of freeglut 2.2.0-8.1

On Wed, Jul 20, 2005 at 09:53:01AM +1000, Jamie Wilkinson wrote:
> I was holding off an upload because of the libGLU c++ transition. Did you
> take that into account?

The direct dependencies have not changed, so there should be no problems.
AFAICT, xlibmesa-gl, xlibmesa-glu and libglut3 have no external ABI
changes.

xlibmesa-gl is still the old version on arm,m68k,mips,mipsel,sparc, so
may not currently build on those platforms (I'm afraid I didn't spot
that), but they should just be put into dep-wait for a few days. Since
it's now built on 7/9 arches, this doesn't appear to be problematic.

> Also, last I checked, contacting the maintainer was a required step in an
> NMU. When were you planning on letting me know your intentions?

This package was one of a list of packages I was asked to fix by the
RM. 0-day NMUs are also OK for GCC 4.0 FTBFS bugs, apparently.

I do normally contact people, but due to the above, and the lack of
any response to the original bug report, I did not. If you had put
a note on the bug report to let people know that you were taking
care of it, I would have left it. As it was, it looked like just
another of the ~400 etch RC FTBFS bugs which had not been fixed by
their (MIA) maintainer.

(http://bts.turmzimmer.net/details.php?ignore=sid&ignpending=on&ignmerged=on&igncontrib=on&ignnonfree=on&new=100&refresh=900)

Regards,
Roger

--
Roger Leigh

                Printing on GNU/Linux? http://gimp-print.sourceforge.net/
                GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 20 Jul 2005 03:49:22 -0700
From: Steve Langasek <email address hidden>
To: Roger Leigh <email address hidden>, <email address hidden>
Cc: Jamie Wilkinson <email address hidden>
Subject: Re: Bug#296242: Fixed in NMU of freeglut 2.2.0-8.1

On Wed, Jul 20, 2005 at 10:34:14AM +0100, Roger Leigh wrote:
> On Wed, Jul 20, 2005 at 09:53:01AM +1000, Jamie Wilkinson wrote:
> > I was holding off an upload because of the libGLU c++ transition. Did you
> > take that into account?

> The direct dependencies have not changed, so there should be no problems.
> AFAICT, xlibmesa-gl, xlibmesa-glu and libglut3 have no external ABI
> changes.

> xlibmesa-gl is still the old version on arm,m68k,mips,mipsel,sparc, so
> may not currently build on those platforms (I'm afraid I didn't spot
> that), but they should just be put into dep-wait for a few days. Since
> it's now built on 7/9 arches, this doesn't appear to be problematic.

> > Also, last I checked, contacting the maintainer was a required step in an
> > NMU. When were you planning on letting me know your intentions?

> This package was one of a list of packages I was asked to fix by the
> RM. 0-day NMUs are also OK for GCC 4.0 FTBFS bugs, apparently.

Nothing I say trumps the requirement to inform maintainers about the changes
you're making to their packages and to make certain for yourself that the
NMU is warranted and correct. Please read this as implicit in any
suggestions I make regarding NMU candidates.

> I do normally contact people, but due to the above, and the lack of
> any response to the original bug report, I did not. If you had put
> a note on the bug report to let people know that you were taking
> care of it, I would have left it. As it was, it looked like just
> another of the ~400 etch RC FTBFS bugs which had not been fixed by
> their (MIA) maintainer.

In this case, there will be a need to update the build-dependencies of
freeglut shortly; there are no ABI transitions taking place for libGLU
(though it was reasonable for Jamie to wait, in light of the confusion
surrounding this question), but the xlibmesa-glu-dev package *is* going away
once the xfree86 source package is phased out in favor of xorg-x11, and
packages will need to build-depend on libglu1-xorg-dev instead.

The net impact is relatively minor, but IMHO it would have been better to
wait for libglu1-xorg-dev to be available on all architectures, and address
both issues at once. In that case, it seems you could have simply let Jamie
do the upload himself. :) Sorry for not being more clear.

--
Steve Langasek
postmodern programmer

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 20 Jul 2005 22:09:08 +0100
From: Roger Leigh <email address hidden>
To: Steve Langasek <email address hidden>
Cc: <email address hidden>, Jamie Wilkinson <email address hidden>
Subject: Re: Bug#296242: Fixed in NMU of freeglut 2.2.0-8.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Steve Langasek <email address hidden> writes:

> On Wed, Jul 20, 2005 at 10:34:14AM +0100, Roger Leigh wrote:
>> On Wed, Jul 20, 2005 at 09:53:01AM +1000, Jamie Wilkinson wrote:

>> > Also, last I checked, contacting the maintainer was a required step in an
>> > NMU. When were you planning on letting me know your intentions?
>
>> This package was one of a list of packages I was asked to fix by the
>> RM. 0-day NMUs are also OK for GCC 4.0 FTBFS bugs, apparently.
>
> Nothing I say trumps the requirement to inform maintainers about the changes
> you're making to their packages and to make certain for yourself that the
> NMU is warranted and correct. Please read this as implicit in any
> suggestions I make regarding NMU candidates.

Please both accept my apologies. I'll make sure to do that in the
future.

Regards,
Roger

- --
Roger Leigh
                Printing on GNU/Linux? http://gimp-print.sourceforge.net/
                Debian GNU/Linux http://www.debian.org/
                GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFC3r1zVcFcaSW/uEgRAnn+AJ9k+L2uQXmFG9+D8BSJ+Z17ueDzvgCg2ixE
OXYEg8xUYEurJoeFvWC4dlQ=
=XiOm
-----END PGP SIGNATURE-----

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Thu, 21 Jul 2005 17:09:58 +1000
From: Jamie Wilkinson <email address hidden>
To: Roger Leigh <email address hidden>
Cc: Steve Langasek <email address hidden>, <email address hidden>
Subject: Re: Bug#296242: Fixed in NMU of freeglut 2.2.0-8.1

This one time, at band camp, Roger Leigh wrote:
>Steve Langasek <email address hidden> writes:
>
>> On Wed, Jul 20, 2005 at 10:34:14AM +0100, Roger Leigh wrote:
>>> On Wed, Jul 20, 2005 at 09:53:01AM +1000, Jamie Wilkinson wrote:
>
>>> > Also, last I checked, contacting the maintainer was a required step in an
>>> > NMU. When were you planning on letting me know your intentions?
>>
>>> This package was one of a list of packages I was asked to fix by the
>>> RM. 0-day NMUs are also OK for GCC 4.0 FTBFS bugs, apparently.
>>
>> Nothing I say trumps the requirement to inform maintainers about the changes
>> you're making to their packages and to make certain for yourself that the
>> NMU is warranted and correct. Please read this as implicit in any
>> suggestions I make regarding NMU candidates.
>
>Please both accept my apologies. I'll make sure to do that in the
>future.

Ok, no problem. I was merely surprised to find an upload without any
mention in the bug report about the intention, and I had not had any coffee.

Revision history for this message
In , Jamie Wilkinson (jaq-spacepants) wrote : Bug#296242: fixed in freeglut 2.4.0-1

Source: freeglut
Source-Version: 2.4.0-1

We believe that the bug you reported is fixed in the latest version of
freeglut, which is due to be installed in the Debian FTP archive:

freeglut3-dbg_2.4.0-1_i386.deb
  to pool/main/f/freeglut/freeglut3-dbg_2.4.0-1_i386.deb
freeglut3-dev_2.4.0-1_i386.deb
  to pool/main/f/freeglut/freeglut3-dev_2.4.0-1_i386.deb
freeglut3_2.4.0-1_i386.deb
  to pool/main/f/freeglut/freeglut3_2.4.0-1_i386.deb
freeglut_2.4.0-1.diff.gz
  to pool/main/f/freeglut/freeglut_2.4.0-1.diff.gz
freeglut_2.4.0-1.dsc
  to pool/main/f/freeglut/freeglut_2.4.0-1.dsc
freeglut_2.4.0.orig.tar.gz
  to pool/main/f/freeglut/freeglut_2.4.0.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jamie Wilkinson <email address hidden> (supplier of updated freeglut package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 13 Oct 2005 09:45:46 +1000
Source: freeglut
Binary: freeglut3-dbg freeglut3-dev freeglut3
Architecture: source i386
Version: 2.4.0-1
Distribution: unstable
Urgency: low
Maintainer: Jamie Wilkinson <email address hidden>
Changed-By: Jamie Wilkinson <email address hidden>
Description:
 freeglut3 - OpenGL Utility Toolkit
 freeglut3-dbg - OpenGL Utility Toolkit debugging information
 freeglut3-dev - OpenGL Utility Toolkit development files
Closes: 248201 265373 293687 296242 306369 319365 323177 325067 331552
Changes:
 freeglut (2.4.0-1) unstable; urgency=low
 .
   * New upstream release. (Closes: #319365, #331552)
     - Fixes key repeat bug. (Closes: #248201, #293687)
     - Remove patch for GLUT_XLIB_IMPLEMENTATION as now fixed upstream.
     - GLUT_ACTION_CONTINUE_EXECUTION fixed in new upstream.
       (Closes: #306369, 325067)
     - Acknowledge NMU 2.2.0-8.1: 64bit fixes incorporated upstream.
       (Closes: #296242)
   * Update build dependencys on libGL and libGLU from Xorg. (Closes: #323177)
   * Remove dependency on transition packages that no longer exist.
     (Closes: #265373)
   * Add build dependency on autogoats.
Files:
 f6e3fc6fa8a0a060894fd019989db663 774 graphics optional freeglut_2.4.0-1.dsc
 6d16873bd876fbf4980a927cfbc496a1 469557 graphics optional freeglut_2.4.0.orig.tar.gz
 56bac09725fb5664729191ba0875a2f9 333817 graphics optional freeglut_2.4.0-1.diff.gz
 7b2ae79c7040147fc90ed31d653b7001 85910 libs optional freeglut3_2.4.0-1_i386.deb
 66eb5ea216dcd13f83f92ba9bc647319 156548 libdevel optional freeglut3-dev_2.4.0-1_i386.deb
 d9d365df24c4307338fc343e76aaa384 142062 libdevel optional freeglut3-dbg_2.4.0-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDTaVw5u9oNyz9HDgRAjEKAKCgvCaaVE9s7I7tJtakjRm3xVhg0QCfZMZH
Ac/IvQftNwYFnPBCBelLvhE=
=Ws+h
-----END PGP SIGNATURE-----

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (3.3 KiB)

Message-Id: <email address hidden>
Date: Wed, 12 Oct 2005 17:17:07 -0700
From: Jamie Wilkinson <email address hidden>
To: <email address hidden>
Subject: Bug#296242: fixed in freeglut 2.4.0-1

Source: freeglut
Source-Version: 2.4.0-1

We believe that the bug you reported is fixed in the latest version of
freeglut, which is due to be installed in the Debian FTP archive:

freeglut3-dbg_2.4.0-1_i386.deb
  to pool/main/f/freeglut/freeglut3-dbg_2.4.0-1_i386.deb
freeglut3-dev_2.4.0-1_i386.deb
  to pool/main/f/freeglut/freeglut3-dev_2.4.0-1_i386.deb
freeglut3_2.4.0-1_i386.deb
  to pool/main/f/freeglut/freeglut3_2.4.0-1_i386.deb
freeglut_2.4.0-1.diff.gz
  to pool/main/f/freeglut/freeglut_2.4.0-1.diff.gz
freeglut_2.4.0-1.dsc
  to pool/main/f/freeglut/freeglut_2.4.0-1.dsc
freeglut_2.4.0.orig.tar.gz
  to pool/main/f/freeglut/freeglut_2.4.0.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jamie Wilkinson <email address hidden> (supplier of updated freeglut package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 13 Oct 2005 09:45:46 +1000
Source: freeglut
Binary: freeglut3-dbg freeglut3-dev freeglut3
Architecture: source i386
Version: 2.4.0-1
Distribution: unstable
Urgency: low
Maintainer: Jamie Wilkinson <email address hidden>
Changed-By: Jamie Wilkinson <email address hidden>
Description:
 freeglut3 - OpenGL Utility Toolkit
 freeglut3-dbg - OpenGL Utility Toolkit debugging information
 freeglut3-dev - OpenGL Utility Toolkit development files
Closes: 248201 265373 293687 296242 306369 319365 323177 325067 331552
Changes:
 freeglut (2.4.0-1) unstable; urgency=low
 .
   * New upstream release. (Closes: #319365, #331552)
     - Fixes key repeat bug. (Closes: #248201, #293687)
     - Remove patch for GLUT_XLIB_IMPLEMENTATION as now fixed upstream.
     - GLUT_ACTION_CONTINUE_EXECUTION fixed in new upstream.
       (Closes: #306369, 325067)
     - Acknowledge NMU 2.2.0-8.1: 64bit fixes incorporated upstream.
       (Closes: #296242)
   * Update build dependencys on libGL and libGLU from Xorg. (Closes: #323177)
   * Remove dependency on transition packages that no longer exist.
     (Closes: #265373)
   * Add build dependency on autogoats.
Files:
 f6e3fc6fa8a0a060894fd019989db663 774 graphics optional freeglut_2.4.0-1.dsc
 6d16873bd876fbf4980a927cfbc496a1 469557 graphics optional freeglut_2.4.0.orig.tar.gz
 56bac09725fb5664729191ba0875a2f9 333817 graphics optional freeglut_2.4.0-1.diff.gz
 7b2ae79c7040147fc90ed31d653b7001 85910 libs optional freeglut3_2.4.0-1_i386.deb
 66eb5ea216dcd13f83f92ba9bc647319 156548 libdevel optional freeglut3-dev_2.4.0-1_i386.deb
 d9d365df24c4307338fc343e76aaa384 142062 libdevel optional freeglut3-dbg_2.4.0-1_i386.deb

-----BEGIN PGP SIGNATURE...

Read more...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.