package-installs doesn't work in python3

Bug #1536462 reported by Matthew Thode
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
diskimage-builder
Fix Released
Undecided
Ian Wienand

Bug Description

the return from popen needs to be run though decode

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to diskimage-builder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/270597

Changed in diskimage-builder:
assignee: nobody → Matthew Thode (prometheanfire)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/273782

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on diskimage-builder (master)
Changed in diskimage-builder:
assignee: Matthew Thode (prometheanfire) → Ian Wienand (iwienand)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to diskimage-builder (master)

Reviewed: https://review.openstack.org/273782
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=c6ef183975045609e361b854edd5dcf8e1c8da37
Submitter: Jenkins
Branch: master

commit c6ef183975045609e361b854edd5dcf8e1c8da37
Author: Matthew Thode <email address hidden>
Date: Thu Jan 28 16:07:01 2016 -0600

    Fix package-installs for python3

    subprocess.check_call() returns a byte-string which needs to be turned
    into a unicode string for python3 compatability.

    Also some minor refactoring while we're here.

    Closes-Bug: 1536462
    Change-Id: Icd957bc4d93ccad94b1246ad62e6e02ee14d9ca5

Changed in diskimage-builder:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.