Invalid fibre channel HBA issue

Bug #1539702 reported by Lucian Petrut
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-win
Fix Released
Undecided
Lucian Petrut

Bug Description

The FC hbaapi library can report invalid HBAs, which it cannot handle.

For example, in case of a VMWare based VM, it can report the SCSI controller as a FC HBA.
We can avoid having issues because of this by simply ignoring adapters that could not be
processed, logging a meaningful message.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (master)

Reviewed: https://review.openstack.org/274174
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=661ea83ab8cd1a2abdfbfead2f3669f5422e2475
Submitter: Jenkins
Branch: master

commit 661ea83ab8cd1a2abdfbfead2f3669f5422e2475
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 29 19:25:17 2016 +0200

    Fibre Channel: Fix invalid HBA adapter issues

    The FC hbaapi library can report invalid HBAs, which it cannot
    handle.

    For example, in case of a VMWare based VM, it can report the
    SCSI controller as a FC HBA.

    We can avoid having issues because of this by simply ignoring
    adapters that could not be processed, logging a meaningful message.

    Change-Id: I46285521ceb60d05a4ccc50b1ccf692bd50d976c
    Closes-Bug: #1539702

Changed in os-win:
status: New → Fix Released
Revision history for this message
Lucian Petrut (petrutlucian94) wrote :

It looks like the above patch didn't fully fix the issue, as fetching the adapter name can fail as well.

Changed in os-win:
status: Fix Released → In Progress
assignee: nobody → Lucian Petrut (petrutlucian94)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-win (master)

Fix proposed to branch: master
Review: https://review.openstack.org/413723

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (master)

Reviewed: https://review.openstack.org/413723
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=b09e79c9a3034178966aa8afedaf01a8f7035a5f
Submitter: Jenkins
Branch: master

commit b09e79c9a3034178966aa8afedaf01a8f7035a5f
Author: Lucian Petrut <email address hidden>
Date: Wed Dec 21 18:36:34 2016 +0200

    FibreChannel: ignore unsupported HBA adapters

    In some cases, when attempting to fetch FC HBA port information, we
    may stumble upon unsupported HBA adapters, which should be ignored.

    A previous patch attempted to fix this issue, assuming that only the
    call fetching FC ports for a specific adapter may fail. It seems like
    in some cases, fetching the adapter name may fail as well.

    This change ensures we're going to catch such exceptions as well.

    Change-Id: I27f9d2062aa0bedb4cb0e6589d8731b77cf30829
    Closes-Bug: #1539702

Changed in os-win:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-win (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/413803

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-win (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/413804

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (stable/newton)

Reviewed: https://review.openstack.org/413804
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=a22eadb4898fe8d0e12ee29f294f9c6019384303
Submitter: Jenkins
Branch: stable/newton

commit a22eadb4898fe8d0e12ee29f294f9c6019384303
Author: Lucian Petrut <email address hidden>
Date: Wed Dec 21 18:36:34 2016 +0200

    FibreChannel: ignore unsupported HBA adapters

    In some cases, when attempting to fetch FC HBA port information, we
    may stumble upon unsupported HBA adapters, which should be ignored.

    A previous patch attempted to fix this issue, assuming that only the
    call fetching FC ports for a specific adapter may fail. It seems like
    in some cases, fetching the adapter name may fail as well.

    This change ensures we're going to catch such exceptions as well.

    Change-Id: I27f9d2062aa0bedb4cb0e6589d8731b77cf30829
    Closes-Bug: #1539702

tags: added: in-stable-newton
tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (stable/mitaka)

Reviewed: https://review.openstack.org/413803
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=d13d6d73101e2d32a14a1080d0a75e62f796ad99
Submitter: Jenkins
Branch: stable/mitaka

commit d13d6d73101e2d32a14a1080d0a75e62f796ad99
Author: Lucian Petrut <email address hidden>
Date: Wed Dec 21 18:36:34 2016 +0200

    FibreChannel: ignore unsupported HBA adapters

    In some cases, when attempting to fetch FC HBA port information, we
    may stumble upon unsupported HBA adapters, which should be ignored.

    A previous patch attempted to fix this issue, assuming that only the
    call fetching FC ports for a specific adapter may fail. It seems like
    in some cases, fetching the adapter name may fail as well.

    This change ensures we're going to catch such exceptions as well.

    Change-Id: I27f9d2062aa0bedb4cb0e6589d8731b77cf30829
    Closes-Bug: #1539702
    (cherry picked from commit b09e79c9a3034178966aa8afedaf01a8f7035a5f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win 1.3.0

This issue was fixed in the openstack/os-win 1.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win 0.5.0

This issue was fixed in the openstack/os-win 0.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win 1.2.2

This issue was fixed in the openstack/os-win 1.2.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.