Launchpad itself

Inifinite loop in team invitation code

Bug #154587 reported by Diogo Matsubara
12
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Brad Crittenden
Launchpad itself 10.09 "Hungry Hippo"

Bug Description

Steps to reproduce:
1. As jdub, open http://launchpad.dev/~guadamen/+addmember
2. Fill in New member: name18
3. Click Add Member
4. A message will be displayed: "name18 has been invited to join guadamen"
5. As stevea, open http://launchpad.dev/~name18/+addmember
6. Fill in New member: guadamen
7. Click Add member
8. A message will be displayed: "guadamen has been invited to join name18"
9. As jdub, open http://launchpad.dev/~guadamen/+invitation/name18
10. Accept the invitation on behalf of name18
11. As stevea, open http://launchpad.dev/~name18/+invitation/guadamen
12. Accept the invitation on behalf of guadamen
13. OOPS-657C1769 RuntimeError maximum recursion depth exceeded

See original description

Related branches

lp:~bac/launchpad/bug-154587
Michael Nelson (community): Approve (code)
Diff: 314 lines (+163/-20)
5 files modified
lib/lp/registry/browser/person.py (+15/-5)
lib/lp/registry/browser/tests/test_person_view.py (+90/-1)
lib/lp/registry/interfaces/teammembership.py (+7/-6)
lib/lp/registry/stories/teammembership/xx-add-member.txt (+8/-8)
lib/lp/registry/tests/test_add_member.py (+43/-0)
Diogo Matsubara (matsubara)
Changed in launchpad:
importance: Undecided → Medium
status: New → Confirmed
assignee: nobody → salgado
Revision history for this message
Guilherme Salgado (salgado) wrote : Unassign myself from untargetted bugs

 assignee nobody
 subscribe

Changed in launchpad:
assignee: salgado → nobody
Revision history for this message
Guilherme Salgado (salgado) wrote :

It's important to note that this only happens if both teams have no contact address.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Medium → Low
status: Confirmed → Triaged
Brad Crittenden (bac)
Changed in launchpad-registry:
status: Triaged → In Progress
assignee: nobody → Brad Crittenden (bac)
assignee: Brad Crittenden (bac) → nobody
milestone: none → 10.09
assignee: nobody → Brad Crittenden (bac)
Brad Crittenden (bac)
description: updated
Revision history for this message
Brad Crittenden (bac) wrote :

This scenario now causes a different OOPS:

CyclicalTeamMembershipError: Cannot make name18 a member of guadamen because guadamen is a member of name18.

This error is entirely appropriate. It should be handled better but prior code changes now recognize the cycle and prevent it from happening.

description: updated
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11492 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11492>.

tags: added: qa-needstesting
Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting registry
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.