Evergreen

angular patron editor: cannot delete addresses

Bug #1550035 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned

Bug Description

When using the angular patron editor to remove an address, then save the patron record, the update fails with the following error:

error calling method open-ils.actor.patron.update : 500 : *** Call to [open-ils.actor.patron.update] failed for session [0.46515691909007731456440793155], thread trace [0]:
Can't call method "id" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Actor.pm line 666.

This boils down to the fact that open-ils.actor.patron.update method is not currently dealing with cases where an address is passed to it with the isdeleted flag set; it can try to update the base patron record's billing_address or mailing_address field, but the relevant code is broken. This is a long-standing issue, but one that wasn't evident to the Dojo patron editor since it handled updating the base patron record's billing_address/mailing_address fields client-side.

Evergreen master

Terran McCanna (tmccanna)
tags: added: webstaffclient
Revision history for this message
Bill Erickson (berick) wrote :

My mileage varied some, in that I get a XACT_COLLISION error when I delete and address. I'm not getting the "undefined value" error. I have pushed a fix to the error I am seeing to the tip of the omnibus branch tracked in bug #1553813. Marking this as a duplicate to avoid confusion.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.