compilation warnings 0.91

Bug #1550917 reported by Franck78
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Inkscape
Invalid
Low
Unassigned

Bug Description

Hello,

Just fyi,

CXX sp-linear-gradient.o
CXX sp-line.o
CXX splivarot.o
CXX sp-lpe-item.o
CXX sp-mask.o

should be 'sp-livarot' no ?

Warnings during compilation

not a lot of them, but not good anyway.
-unused variable [ 3 warnings ]
-uninitialized [ 5 warnings ]
-string? [ 2 warnings ]
-overflow [1 warning ]

libcroco/cr-statement.c: In function ‘cr_statement_at_import_rule_parse_from_buf’:
libcroco/cr-statement.c:1428:24: warning: variable ‘cur’ set but not used [-Wunused-but-set-variable]
                 GList *cur = NULL;

libcroco/cr-style.c: In function ‘set_prop_position_from_value’:
libcroco/cr-style.c:870:23: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
         enum CRStatus status = CR_UNKNOWN_PROP_VAL_ERROR;

sp-hatch-path.cpp: In member function ‘Geom::Interval SPHatchPath::bounds() const’:
sp-hatch-path.cpp:228:51: warning: ‘*((void*)& bbox +16)’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     result.setMax(bbox->right() + stroke_width / 2);
                                                   ^
sp-hatch-path.cpp:227:50: warning: ‘*((void*)& bbox +8)’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     result.setMin(bbox->left() - stroke_width / 2);
                                                  ^

style.cpp: In constructor ‘SPStyle::SPStyle(SPDocument*, SPObject*)’:
style.cpp:193:91: warning: deprecated conversion from string constant to ‘gchar* {aka char*}’ [-Wwrite-strings]
     text_rendering( "text-rendering", enum_text_rendering, SP_CSS_TEXT_RENDERING_AUTO )
                                                                                           ^

In file included from ./2geom/interval.h:45:0,
                 from ./2geom/rect.h:45,
                 from display/sp-canvas.cpp:26:
./2geom/generic-interval.h:143:8: warning: ‘*((void*)(& bounds)+24).Geom::GenericInterval<double>::_b[0]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
        if(val < _b[0]) _b[0] = val;
        ^
display/sp-canvas.cpp:1051:19: note: ‘*((void*)(& bounds)+24).Geom::GenericInterval<double>::_b[0]’ was declared here
     Geom::OptRect bounds;
                   ^
In file included from ./2geom/interval.h:45:0,
                 from ./2geom/rect.h:45,
                 from display/sp-canvas.cpp:26:
./2geom/generic-interval.h:144:8: warning: ‘*((void*)(& bounds)+8).Geom::GenericInterval<double>::_b[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
        if(val > _b[1]) _b[1] = val; //no else, as we want to handle NaN
        ^
display/sp-canvas.cpp:1051:19: note: ‘*((void*)(& bounds)+8).Geom::GenericInterval<double>::_b[1]’ was declared here
     Geom::OptRect bounds;
                   ^

libnrtype/Layout-TNG-Compute.cpp:1530:76: warning: ‘last_span_at_emergency_break.Inkscape::Text::Layout::Calculator::BrokenSpan::word_spacing’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                 chunk_info->back().broken_spans.back() = last_span_at_break;
                                                                            ^

svg/svg-angle.cpp: In member function ‘bool SVGAngle::read(const gchar*)’:
svg/svg-angle.cpp:57:14: warning: ‘v’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     value = v;
              ^

ui/dialog/document-properties.cpp: In member function ‘void Inkscape::UI::Dialog::DocumentProperties::onDocUnitChange()’:
ui/dialog/document-properties.cpp:1696:33: warning: variable ‘old_doc_unit’ set but not used [-Wunused-but-set-variable]
     Inkscape::Util::Unit const *old_doc_unit = unit_table.getUnit("px");
                                 ^

./2geom/generic-interval.h: In member function ‘void Inkscape::UI::Tools::CalligraphicTool::brush()’:
./2geom/generic-interval.h:65:9: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
         if (u <= v) {
         ^

ui/widget/selected-style.cpp:112:1: warning: deprecated conversion from string constant to ‘gchar* {aka char*}’ [-Wwrite-strings]
 };
 ^

jazzynico (jazzynico)
tags: added: build code-design
removed: compiler warnings
Changed in inkscape:
importance: Undecided → Low
Revision history for this message
Qantas94Heavy (qantas94heavy) wrote :

Closing because this is managed normally in the development process and probably does not need a separate bug report.

Closed by: https://gitlab.com/Qantas94Heavy

Changed in inkscape:
status: New → Invalid
tbnorth (terry-n-brown)
tags: added: bug-migration
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.