'service provider show' returns a service provider when queried with wrong sp_id

Bug #1555830 reported by Kristi Nikolla
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Steve Martinelli
python-openstackclient
Fix Released
Medium
Steve Martinelli

Bug Description

ubuntu@k2k-idp3:~$ openstack service provider list
+-------------+---------+-------------+---------------------------------------------------------------------------------------------------+
| ID | Enabled | Description | Auth URL |
+-------------+---------+-------------+---------------------------------------------------------------------------------------------------+
| keystone-sp | True | None | http://xxx.xxx.xxx.xxx:35357/v3/OS-FEDERATION/identity_providers/keystone-idp/protocols/saml2/auth |
+-------------+---------+-------------+---------------------------------------------------------------------------------------------------+
ubuntu@k2k-idp3:~$ openstack service provider show nonexistent
+--------------------+---------------------------------------------------------------------------------------------------+
| Field | Value |
+--------------------+---------------------------------------------------------------------------------------------------+
| auth_url | http://xxx.xxx.xxx.xxx:35357/v3/OS-FEDERATION/identity_providers/keystone-idp/protocols/saml2/auth |
| description | None |
| enabled | True |
| id | keystone-sp |
| relay_state_prefix | ss:mem: |
| sp_url | http://xxx.xxx.xxx.xxx:5000/Shibboleth.sso/SAML2/ECP |
+--------------------+---------------------------------------------------------------------------------------------------+
ubuntu@k2k-idp3:~$ pip show python-openstackclient
---
Metadata-Version: 2.0
Name: python-openstackclient
Version: 2.2.0

Revision history for this message
Steve Martinelli (stevemar) wrote :

Sounds like https://bugs.launchpad.net/python-openstackclient/+bug/1479837 all over again. I'm guessing it affects the protocol/mapping too.

Can you confirm the bug is *fixed* for identity providers?

Revision history for this message
Kristi Nikolla (knikolla) wrote :

I get the same thing with identity providers. I'm running stable/liberty so if the fix for 1479837 hasn't been backported then I guess it is expected.

ubuntu@k2k-devstack-sp:~$ openstack identity provider list
+--------------+---------+-------------+
| ID | Enabled | Description |
+--------------+---------+-------------+
| keystone-idp | True | None |
+--------------+---------+-------------+
ubuntu@k2k-devstack-sp:~$ openstack identity provider show hello
+-------------+---------------------------------------------------------+
| Field | Value |
+-------------+---------------------------------------------------------+
| description | None |
| enabled | True |
| id | keystone-idp |
| remote_ids | http://xxx.xxx.xxx.xxx:35357/v3/OS-FEDERATION/saml2/idp |
+-------------+---------------------------------------------------------+
ubuntu@k2k-devstack-sp:~$

Revision history for this message
Steve Martinelli (stevemar) wrote :

It has not been backported so that makes sense. you can propose to backport it using gerrit.

Changed in keystone:
milestone: none → mitaka-rc1
Revision history for this message
Steve Martinelli (stevemar) wrote :
Changed in keystone:
status: New → In Progress
Changed in python-openstackclient:
status: New → In Progress
Changed in keystone:
assignee: nobody → Steve Martinelli (stevemar)
Changed in python-openstackclient:
assignee: nobody → Steve Martinelli (stevemar)
Changed in keystone:
importance: Undecided → Medium
Changed in python-openstackclient:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/291584
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=cecf6048f2018e7cea864e3a6ff18b9088ac4254
Submitter: Jenkins
Branch: master

commit cecf6048f2018e7cea864e3a6ff18b9088ac4254
Author: Steve Martinelli <email address hidden>
Date: Fri Mar 11 02:45:53 2016 -0500

    Support `id` and `enabled` attributes when listing service providers

    list SPs currently doesn't support to filter records by any
    attributes, but this is used somewhere, such as OpenStack
    Client using `name` to filter the record.

    SP doesn't has `name` attribute but has `id`, `enabled`
    attributes instead.

    This patch enables the filtering of Service Provider based
    on `id`, `enabled` attributes so that OpenStack Client or the
    CURL query can benefit from it.

    based off of: Ib672ba759d26bdd0eecd48451994b3451fb8648a

    Closes-Bug: 1555830

    Change-Id: Icdecaa44415786397ee8bb22de16d25cb8fe603a

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystone 9.0.0.0rc1

This issue was fixed in the openstack/keystone 9.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/291620
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=58094bff80584ba9afac0073aea545a96a170bff
Submitter: Jenkins
Branch: master

commit 58094bff80584ba9afac0073aea545a96a170bff
Author: Steve Martinelli <email address hidden>
Date: Fri Mar 11 04:06:18 2016 -0500

    Search by user defined ID for service providers

    IDs for service providers can be user defined (like, Bob). This
    causes issues with the usual get by ID method.

    Keystone server side has implemented changes to search by ID when
    listing, which should resolve the issue with minimal changes to
    the client side.

    Change-Id: Ic705806e4bc7bb24f946a1fce803a0a0a4d788c1
    Closes-Bug: 1555830

Changed in python-openstackclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-openstackclient 2.5.0

This issue was fixed in the openstack/python-openstackclient 2.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.