Launchpad itself

AssertionError triggered listing questions

Bug #157074 reported by Diogo Matsubara
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Unassigned

Bug Description

Module canonical.launchpad.browser.questiontarget, line 417, in formatSourcePackageName
    assert self.context == question.distribution
AssertionError

OOPS-656A12, OOPS-662A1628

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Assigning to Curtis who will commit a patch adding more debug information to that assert statement.

Changed in launchpad-answers:
assignee: nobody → sinzui-is
Curtis Hovey (sinzui)
Changed in launchpad-answers:
importance: Undecided → High
milestone: none → 1.1.11
status: New → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in RF 5115.

Changed in launchpad-answers:
status: In Progress → Fix Committed
Revision history for this message
Diogo Matsubara (matsubara) wrote :

I don't agree this was fixed by r5115. I think we should leave it as Incomplete and add more information as soon as a new oops is triggered with the new assert message in place.

Changed in launchpad-answers:
importance: High → Medium
status: Fix Committed → Incomplete
Francis J. Lacoste (flacoste)
Changed in launchpad-answers:
milestone: 1.1.11 → none
Revision history for this message
Diogo Matsubara (matsubara) wrote :

New oops with more debug information: OOPS-695D151

Changed in launchpad-answers:
status: Incomplete → Confirmed
Curtis Hovey (sinzui)
Changed in launchpad-answers:
milestone: none → 1.1.12
Revision history for this message
Curtis Hovey (sinzui) wrote :

SecurityProxy on the two objects that failed the assert implies we are seeing the SQLObject nonsense. This looks tricky to test. Our tests suite checks this line of code about 100 times without error. I think the problem we are seeing is related to where SQLObject cannot identify that two objects are equivalent when multiple instances are created across transactions.

I have a clear way to rewrite method to use target property instead of the specific objects. That will also let us avoid a needless lookup of the distributionSourcePackage when we already have it.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in RF 5228.

Changed in launchpad-answers:
status: Confirmed → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fix released in 1.1..11.cherry-pick.

Changed in launchpad-answers:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.