kolla-build return wrong exit code

Bug #1578404 reported by Stephane Boisvert
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Undecided
Unassigned

Bug Description

running kolla-build in jenkins. I figured out that the return code is always 1 even if the build is done without any error

See the logs here

http://paste.openstack.org/show/496163/

Revision history for this message
Hui Kang (huikang27) wrote :

what is the command you use to build kolla image? Thanks. - Hui

Revision history for this message
Stephane Boisvert (stephane-boisvert) wrote :

kolla-build --push --nocache --type source --base ubuntu --registry myregistry.example.com:5000 --namespace dev -T 10 --include-header docker.file

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/322115
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=18ae114e7557ecc0a5692ea3a22b418df7bba52f
Submitter: Jenkins
Branch: master

commit 18ae114e7557ecc0a5692ea3a22b418df7bba52f
Author: Will Miller <email address hidden>
Date: Wed May 25 04:04:52 2016 -0500

    Fix kolla-build return codes

    Add a main wrapper function to return 1 if any images failed to build;
    otherwise, return 0. Rename the old main() to run_build(), which still
    returns image statuses, to avoid interfering with unit tests.

    Change-Id: I5817cc9cebb4f42dc13e0535223e5dc8931a3aab
    Co-Authored-By: Mark Goddard <email address hidden>
    Closes-Bug: #1578404

Changed in kolla:
status: New → Fix Released
Revision history for this message
Christian Berendt (berendt) wrote :

After the merge of this change I got the following error when running with the parameter --template-only:

kolla-build --config-file kolla-build.conf --template-only neutron
INFO:kolla.cmd.build:Found the docker image folder at /usr/local/share/kolla/docker
INFO:kolla.cmd.build:Dockerfiles are generated in /tmp/kolla-2016-05-31_16-31-59_ctuce_/docker
Traceback (most recent call last):
  File "/usr/local/bin/kolla-build", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/kolla/cmd/build.py", line 795, in main
    bad_results, good_results, unmatched_results = run_build()
TypeError: 'NoneType' object is not iterable

Revision history for this message
Christian Berendt (berendt) wrote :

Reported in a separate bug report: https://bugs.launchpad.net/kolla/+bug/1587501

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 3.0.0.0b1

This issue was fixed in the openstack/kolla 3.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.