Client Developer Experience

Running an app on the phone with the SDK gets python spinning on 100% cpu

Bug #1584093 reported by Michael Zanetti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Client Developer Experience
Fix Released
Critical
Zoltan Balogh
qtcreator-plugin-ubuntu (Ubuntu)
Fix Released
Undecided
Benjamin Zeller

Bug Description

Run an app on the phone with the SDK. python will spin at 100% cpu permanently. This causes multiple issues:

* it's odd to debug your apps because they are slowed down a lot

* while developing with the device, battery drains faster than it charges, even though plugged to the PC.

* High power devices like turbo actually start to get *very* hot - I'm kinda worried of breaking it in the long run with this - especially the battery.

* when you unplug the device without first stopping the app, this gets stuck and requires a reboot.

Related branches

lp:~zeller-benjamin/qtcreator-plugin-ubuntu/lxd-release
ubuntu-sdk-build-bot: Needs Fixing (continuous-integration)
Zoltan Balogh: Approve
Diff: 8806 lines (+4250/-2454)
85 files modified
UbuntuPlugin.pro (+73/-60)
chroot-agent/chroot-agent.pro (+0/-59)
chroot-agent/chrootagent.cpp (+0/-384)
chroot-agent/chrootagent.h (+0/-67)
chroot-agent/main.cpp (+0/-275)
debian/control (+2/-10)
share/qtcreator/ubuntu/menu.json (+2/-91)
share/qtcreator/ubuntu/qml/welcome.qml (+2/-2)
share/qtcreator/ubuntu/scripts/click_create_target (+0/-47)
share/qtcreator/ubuntu/scripts/click_destroy_target (+0/-73)
share/qtcreator/ubuntu/scripts/container_publickey_deploy (+76/-0)
share/qtcreator/ubuntu/scripts/device_publickey_deploy (+70/-0)
share/qtcreator/ubuntu/scripts/openssh_publickey_create (+15/-46)
share/qtcreator/ubuntu/scripts/qtc_chroot_get_upgrades.py (+6/-24)
share/qtcreator/ubuntu/scripts/qtc_chroot_wrapper.py (+0/-187)
share/qtcreator/ubuntu/scripts/qtc_device_applaunch.py (+66/-57)
share/qtcreator/ubuntu/scripts/qtc_project_make (+0/-20)
share/qtcreator/ubuntu/scripts/usdk-target-build (+839/-0)
src/ubuntu/clicktoolchain.cpp (+9/-24)
src/ubuntu/device/container/containerdevice.cpp (+265/-0)
src/ubuntu/device/container/containerdevice.h (+45/-0)
src/ubuntu/device/container/containerdevice_p.h (+50/-0)
src/ubuntu/device/container/containerdevicefactory.cpp (+74/-0)
src/ubuntu/device/container/containerdevicefactory.h (+28/-0)
src/ubuntu/device/container/containerdeviceprocess.cpp (+96/-0)
src/ubuntu/device/container/containerdeviceprocess.h (+39/-0)
src/ubuntu/device/container/containerdevicesignaloperation.cpp (+152/-0)
src/ubuntu/device/container/containerdevicesignaloperation.h (+45/-0)
src/ubuntu/device/container/containerprocesslist.cpp (+95/-0)
src/ubuntu/device/container/containerprocesslist.h (+36/-0)
src/ubuntu/device/container/ubuntulocaldeployconfiguration.cpp (+3/-3)
src/ubuntu/device/container/ubuntulocalrunconfiguration.cpp (+99/-31)
src/ubuntu/device/container/ubuntulocalrunconfiguration.h (+15/-9)
src/ubuntu/device/container/ubuntulocalrunconfigurationfactory.cpp (+10/-8)
src/ubuntu/device/container/ubuntulocalrunconfigurationfactory.h (+2/-2)
src/ubuntu/device/container/ubuntulocalruncontrolfactory.cpp (+91/-114)
src/ubuntu/device/container/ubuntulocalruncontrolfactory.h (+1/-0)
src/ubuntu/device/container/ubuntulocalscopedebugsupport.cpp (+154/-85)
src/ubuntu/device/container/ubuntulocalscopedebugsupport.h (+22/-18)
src/ubuntu/device/remote/ubuntudeploystepfactory.cpp (+4/-3)
src/ubuntu/device/remote/ubuntudevice.cpp (+7/-6)
src/ubuntu/device/remote/ubuntudevicefactory.cpp (+1/-1)
src/ubuntu/device/remote/ubuntudevicesignaloperation.cpp (+1/-1)
src/ubuntu/device/remote/ubuntudirectuploadstep.cpp (+6/-5)
src/ubuntu/device/remote/ubuntuemulatornotifier.cpp (+1/-1)
src/ubuntu/device/remote/ubunturemoteanalyzesupport.cpp (+1/-1)
src/ubuntu/device/remote/ubunturemotedebugsupport.cpp (+1/-1)
src/ubuntu/device/remote/ubunturemotedeployconfiguration.cpp (+4/-4)
src/ubuntu/device/remote/ubunturemoterunconfiguration.cpp (+8/-7)
src/ubuntu/device/remote/ubunturemoteruncontrol.cpp (+1/-1)
src/ubuntu/device/remote/ubunturemoteruncontrolfactory.h (+1/-1)
src/ubuntu/processoutputdialog.cpp (+71/-136)
src/ubuntu/processoutputdialog.h (+17/-20)
src/ubuntu/processoutputdialog.ui (+108/-44)
src/ubuntu/settings.cpp (+13/-0)
src/ubuntu/settings.h (+3/-0)
src/ubuntu/targetupgrademanager.cpp (+3/-4)
src/ubuntu/ubuntuclickdialog.cpp (+121/-0)
src/ubuntu/ubuntuclickdialog.h (+38/-0)
src/ubuntu/ubuntuclicktool.cpp (+199/-180)
src/ubuntu/ubuntuclicktool.h (+16/-12)
src/ubuntu/ubuntuconstants.h (+30/-24)
src/ubuntu/ubuntudevicemode.h (+1/-1)
src/ubuntu/ubuntudevicesmodel.h (+4/-2)
src/ubuntu/ubuntukitmanager.cpp (+188/-96)
src/ubuntu/ubuntukitmanager.h (+2/-1)
src/ubuntu/ubuntumenu.cpp (+1/-2)
src/ubuntu/ubuntupackagingmodel.cpp (+1/-1)
src/ubuntu/ubuntuplugin.cpp (+111/-33)
src/ubuntu/ubuntuplugin.h (+3/-0)
src/ubuntu/ubuntuproject.cpp (+0/-3)
src/ubuntu/ubuntuqtversion.cpp (+15/-0)
src/ubuntu/ubuntuqtversion.h (+5/-0)
src/ubuntu/ubuntusettingsclickwidget.cpp (+11/-8)
src/ubuntu/ubuntusettingsclickwidget.h (+1/-1)
src/ubuntu/ubuntusettingsclickwidget.ui (+2/-2)
src/ubuntu/wizards/createtargetimagepage.ui (+141/-67)
src/ubuntu/wizards/createtargetintropage.ui (+88/-0)
src/ubuntu/wizards/createtargetnamepage.ui (+38/-0)
src/ubuntu/wizards/createtargetwizard.cpp (+367/-49)
src/ubuntu/wizards/createtargetwizard.h (+111/-15)
src/ubuntu/wizards/ubuntufatpackagingwizard.cpp (+1/-1)
src/ubuntu/wizards/ubuntufirstrunwizard.cpp (+9/-12)
src/ubuntu/wizards/ubuntuprojectapplicationwizard.cpp (+12/-10)
ubuntu.pro (+1/-2)
lp:qtcreator-plugin-ubuntu
Michael Zanetti (mzanetti)
summary: - Running an app on the phone with the SDK gety python spinning on 100%
+ Running an app on the phone with the SDK gets python spinning on 100%
cpu
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

What are we using python for here btw?

Changed in canonical-developer-experience:
assignee: nobody → Zoltan Balogh (bzoltan)
importance: Undecided → Critical
Changed in qtcreator-plugin-ubuntu (Ubuntu):
assignee: nobody → Benjamin Zeller (zeller-benjamin)
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

Python is used here for several things:

1. Installing the uploaded click package
2. Setting up a debug environment
3. Executing the app using the hook specified in the RC
4. Redirecting the stdout and stderr of the application so it can be read by QtC
5. Waiting for the app to finish (using upstart events)
6. Cleaning up after the session is finished

Benjamin Zeller (zeller-benjamin)
Changed in canonical-developer-experience:
status: New → Confirmed
Changed in qtcreator-plugin-ubuntu (Ubuntu):
status: New → Confirmed
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

I can confirm the problem, and it seems it is due to us reading syslog and syslog
getting constant updates. ( tail -f /var/log/syslog).

The script needs to parse every syslog line for potential apparmor errors which is
expensive. There was another issue with listening on the pipes but it alone did not
solve the problem. Only completely disabling the parsing of syslog updates stops python
from taking up CPU.

The question is now do we want to drop reading syslog files or do we live with the CPU
consumption...

Another question is though why syslog is flooded with messages.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

I've just tried this and I don't have a flooded syslog. I get in average some 4 messages per second in syslog, something nothing for a few seconds. Still python spins on 100%.

Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

After some more debugging with Michael it seems the flooding is local to my device.
However we were able to confirm that the syslog code is causing python to spin on
100% CPU. I will try to figure out a different way to follow changes in the syslog file.

Benjamin Zeller (zeller-benjamin)
Changed in canonical-developer-experience:
status: Confirmed → Fix Committed
Changed in qtcreator-plugin-ubuntu (Ubuntu):
status: Confirmed → Fix Committed
Benjamin Zeller (zeller-benjamin)
Changed in qtcreator-plugin-ubuntu (Ubuntu):
status: Fix Committed → Fix Released
Changed in canonical-developer-experience:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.