Install hook fails for bzr projects
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Charm Helpers |
In Progress
|
High
|
Marco Ceppi |
Bug Description
We've been trying unsuccessfully to deploy ubucon.org with Juju, which worked fine for a few months until recently. We've tracked it to be a failed install hook that fails at doing a bzr checkout:
You can see it in the code that that can never work:
1. Create directory
2. If directory exists, do a `bzr pull`
3. Of course the directory exists, but it's not a bzr branch, so the `pull` fails
I've noticed this stopped working after the charm helpers migration to Python 3.0, where the original bzr API code was replaced by process calls. However, in doing the replacement, it seems the tests were not updated, as they seem to pass even though the code does not work.
Steps to reproduce:
cd $HOME/charms/layers
bzr branch lp:~ubucon-site-developers/ubucon-site/ubucon-layer ubucon
cd ubucon
charm build
juju deploy postgresql
juju deploy $HOME/charms/
# Deployment fails during the deploy step, as the
# install hook cannot do a bzr checkout of the site's code
juju add-relation postgresql:db ubucon
juju expose ubucon
Related branches
- Stuart Bishop (community): Approve
-
Diff: 51 lines (+20/-7)2 files modifiedcharmhelpers/fetch/bzrurl.py (+3/-2)
tests/fetch/test_bzrurl.py (+17/-5)
description: | updated |
description: | updated |
Changed in charm-helpers: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in charm-helpers: | |
status: | Triaged → In Progress |
assignee: | nobody → Marco Ceppi (marcoceppi) |