Oxide

navigator.vibrate doesn't actually work

Bug #1593232 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
Critical
Chris Coulson
Oxide branch-1.17

Bug Description

This functionality has no tests, so I thought I'd write some, only to discover that the feature doesn't actually work (the empty device::VibrationManager stub in Chromium is always used)

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

So, this broke with https://chromium.googlesource.com/chromium/src.git/+/a233ca418eda4eadf27339cf1efab9f5930e5abb, which moved it to a frame service rather than a process service.

We really need to stop adding features like this with no tests.

Changed in oxide:
assignee: nobody → Chris Coulson (chrisccoulson)
status: New → In Progress
importance: Undecided → Critical
milestone: none → branch-1.17
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Fixed with https://git.launchpad.net/oxide/commit/?id=ad2d915452cd757613ac12f078c64f83c19100b9

Changed in oxide:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.