OVS firewall code should look at vlan to position port/network register

Bug #1593760 reported by Thomas Morin
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Confirmed
Medium
Jakub Libosvar

Bug Description

[1] only looks at the packet destination MAC without considering the network context (ie. VLAN) in which the packet is received, which may lead to issues if a given MAC is not unique across Networks.

[1] https://github.com/openstack/neutron/blob/master/neutron/agent/linux/openvswitch_firewall/firewall.py#L356

IRC discussion here: http://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2016-06-17.log.html#t2016-06-17T14:23:33

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/331198

Changed in neutron:
assignee: nobody → Thomas Morin (tmmorin-orange)
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
tags: added: mitaka-backport-potential
tags: added: sg-fw
Changed in neutron:
assignee: Thomas Morin (tmmorin-orange) → Jakub Libosvar (libosvar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/331198
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Do we have an update on this one?

Changed in neutron:
status: In Progress → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.