Camera image is rotated by 90° on M10 because Qt says the screen's native orientation is portrait

I think the inversion was already there, and is something done by the hangouts app itself, on purpose. The rotation clearly is a recent regression though.

Yes, the hangouts app mirrors the camera preview - the actual image sent to other parties is not mirrored.

This isn't a bug in Oxide - QScreen::nativeOrientation says the native orientation is portrait, when it should be landscape. This needs to be correct because the camera orientation is referenced to this

This probably isn't clear to anyone else looking at this bug, but Oxide rotates the camera image based on the current device rotation and the native camera orientation, which we get from the Android camera service via libhybris, using this API:

https://developer.android.com/reference/android/hardware/Camera.html#getCameraInfo(int, android.hardware.Camera.CameraInfo)

The returned native orientation is described in the documentation as (see https://developer.android.com/reference/android/hardware/Camera.CameraInfo.html#orientation):

"The orientation of the camera image. The value is the angle that the camera image needs to be rotated clockwise so it shows correctly on the display in its natural orientation"

In order to do this, we need to know the rotation of the device, which we calculate using the current device orientation referenced to its native orientation.

In this case, the native orientation is incorrect - QScreen::nativeOrientation returns portrait. It should be landscape for the M10 (and other tablets).

Oxide is doing exactly the same thing as Chrome/Android, except that Chrome uses Android's Display.getRotation() API ( https://developer.android.com/reference/android/view/Display.html#getRotation() )

Not sure if its a directly related issue but the E5 image is upside down, which also used to work correctly. Obviously something regressed. If that doesn't sound related I can open a new bug.

vegetahd probably has the same issue as krillin (bug 1567542), which is actually a device bug. I haven't got one of those though.

@chris right, the devices are essentially the same so we can't special case one without the other

The M10's lcd panel is actually a portrait lcd mounted 90degrees:

phablet@frieza:~$ MIR_SOCKET=/run/mir_socket mirout
Connected to server: <default>
Card 0: Max 3 simultaneous outputs
Output 1: Card 0, LVDS, connected, 1200x1920+0+0, used, on, 135mm x 216mm (10.0"), normal
    1200x1920 56.91*+
Output 2: Card 0, DisplayPort, disconnected
Output 3: Card 0, Virtual, disconnected
    1920x1080 60.00*+

See how the LVDS output (to the lcd) has width 1200 and height 1920.

QtUbuntu relies on these values to guess the native orientation of the display. But it has no idea the panel is actually mounted 90degrees. I believe the graphics driver rotates the actual display too, further confusing things.

Unless we've a way to determine the rotation of the lcd in the housing, I suspect we'll need a per-device quirk to make sure qtubuntu or mir returns the display dimensions we actually want.

This was worked around in oxide with https://git.launchpad.net/oxide/commit/?id=2e5f300fbce422b648377a30fc633d8edb2fb638.

And that fix was backported in the 1.16 branch: https://git.launchpad.net/oxide/commit/?id=0a98ec8a6474bde096465555477a4c1418fc760f.

Confirmed fixed on 'cooler' by release 1.16.8 of oxide