Evergreen

DB Migration 2.10.0 - circ history migration confusing status message

Bug #1612873 reported by Josh Stompro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 2.12-beta
2.10
Fix Released
Low
Unassigned
Evergreen 2.10.8
2.11
Fix Released
Low
Unassigned
Evergreen 2.11.1

Bug Description

EG 2.9.3 to 2.10 upgrade script.

I've seen this a few times now when doing test upgrades. When the upgrade gets to the circ history migration to the new table, the following informational messages appear.

psql:version-upgrade/2.9.3-2.10.0-upgrade-db.sql:1567: NOTICE: Migrating circ history for 13105 users. This might take a while...
psql:version-upgrade/2.9.3-2.10.0-upgrade-db.sql:1567: NOTICE: Migrated history for 10000 total users
psql:version-upgrade/2.9.3-2.10.0-upgrade-db.sql:1567: NOTICE: Migrated history for 20000 total users
psql:version-upgrade/2.9.3-2.10.0-upgrade-db.sql:1567: NOTICE: Migrated history for 30000 total users
psql:version-upgrade/2.9.3-2.10.0-upgrade-db.sql:1567: NOTICE: Migrated history for 40000 total users
psql:version-upgrade/2.9.3-2.10.0-upgrade-db.sql:1567: NOTICE: Migrated history for 50000 total users

This throws me off since it states that it is migrating history for 13105 users, and then displays a counter with the label of users that goes far past that number.

Instead of users it should say circs since the counter is counting all the circs that are being migrated.

This has no effect on the outcome, just caused me to wonder what was going on.

Josh

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Branch to fix this is at

user/stompro/lp1612873_circ_history_upgrade_notify

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1612873_circ_history_upgrade_notify

Josh

tags: added: pullrequest
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Signoff branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1612873_circ_history_upgrade_notify

tags: added: signedoff
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 2.10.8
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_2_11, and rel_2_10. Thanks, Josh and Chris!

Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.10.8 → 2.next
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.next → 2.12-beta
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.