Neutron Objects do not override the UUIDField to actually validate UUIDs

Bug #1614537 reported by Graham Hayes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
zainub

Bug Description

Oslo Versioned Objects' implementation of the UUID Field does not actually validate anything.

It is a wrapper around a string type.

Projects are advised that to actually validate UUIDs, they need to override the field in their custom fields. [1]

Leaving it non validating can cause issues when the field is moved to validate, or there is an assumption that it is being validated.

1 - http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/357302

Changed in neutron:
assignee: nobody → Graham Hayes (grahamhayes)
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/357302
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
assignee: Graham Hayes (grahamhayes) → nobody
status: In Progress → Confirmed
tags: added: low-hanging-fruit
Revision history for this message
Zainub (zainub) wrote :

I want to solve this bug.

zainub (zainub.wahid)
Changed in neutron:
assignee: nobody → zainub (zainub.wahid)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/393150

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/393189

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Zainub Wahid (<email address hidden>) on branch: master
Review: https://review.openstack.org/393189

Changed in neutron:
assignee: zainub (zainub.wahid) → Graham Hayes (grahamhayes)
status: Confirmed → In Progress
Changed in neutron:
assignee: Graham Hayes (grahamhayes) → zainub (zainub.wahid)
zainub (zainub.wahid)
Changed in neutron:
assignee: zainub (zainub.wahid) → nobody
Changed in neutron:
assignee: nobody → zainub (zainub.wahid)
Changed in neutron:
assignee: zainub (zainub.wahid) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → zainub (zainub.wahid)
description: updated
Changed in neutron:
assignee: zainub (zainub.wahid) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → zainub (zainub.wahid)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/393150
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bb78621a72bb0f54205fac57e19d4679143bc3f3
Submitter: Jenkins
Branch: master

commit bb78621a72bb0f54205fac57e19d4679143bc3f3
Author: Zainub Wahid <email address hidden>
Date: Thu Nov 3 12:57:25 2016 +0500

    Make UUIDField actually validate UUIDs

    Instead of using oslo.versionedobjects UUID type, use a custom UUIDField
    class located in common_types that will actually validate passed values
    for UUID-ness.

    Closes-Bug: #1614537
    Change-Id: I20b24ee57c521b1c68977c2ff7ae56b56875dd64

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.0.0b2

This issue was fixed in the openstack/neutron 10.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/357302
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.