iptables rule always be thrashed when update a little rule

Bug #1618879 reported by Zhengwei Gao
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Security Advisory
Won't Fix
Undecided
Unassigned
neutron
Fix Released
Undecided
Brian Haley

Bug Description

When update meter label or rule, iptables_manager will update iptables rule in router's namespace. In order to, it will clean traffic counter number collected in interval time, the other iptables always trashing that will clean old iptalbes rule and generate new same significance iptables rule.

the example from update meter label:

Generated by iptables_manager
*filter
:neutron-meter-neutron-met - [0:0]
:neutron-meter-r-00599199-632 - [0:0]
-I FORWARD 2 -j neutron-meter-FORWARD
-D FORWARD 4
-I INPUT 1 -j neutron-meter-INPUT
-D INPUT 3
-I OUTPUT 2 -j neutron-meter-OUTPUT
-D OUTPUT 4
-I neutron-filter-top 1 -j neutron-meter-local
-D neutron-filter-top 3
-D neutron-meter-l-00e4e019-099 1
-I neutron-meter-l-00e4e019-099 1
-D neutron-meter-l-01e4e019-099 1
-I neutron-meter-l-01e4e019-099 1
-I neutron-meter-r-00599199-632 1 -i qg-f0732f6f-8e -d 192.168.10.0/24 -j neutron-meter-l-00599199-632
COMMIT
# Completed by iptables_manager
# Generated by iptables_manager
*raw
-I OUTPUT 1 -j neutron-meter-OUTPUT
-D OUTPUT 3
-I PREROUTING 1 -j neutron-meter-PREROUTING
-D PREROUTING 3
COMMIT
# Completed by iptables_manager

Changed in neutron:
assignee: nobody → Zhengwei Gao (multi-task)
status: New → In Progress
information type: Private Security → Public Security
Revision history for this message
Tristan Cacqueray (tristan-cacqueray) wrote :

Since this report concerns a possible security risk, an incomplete security advisory task has been added while the core security reviewers for the affected project or projects confirm the bug and discuss the scope of any vulnerability along with potential solutions.

I've add the OSSA task since it's reported as a Security bug, though it doesn't like a vulnerability but more of a bug with (some) security implications (class D according to VMT taxonomy).

Changed in ossa:
status: New → Incomplete
Revision history for this message
Zhengwei Gao (multi-task) wrote :
Changed in neutron:
assignee: Zhengwei Gao (multi-task) → Brian Haley (brian-haley)
Changed in neutron:
milestone: none → newton-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/364019
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5b7c71a327d735134fa0eeb4427d0e1bd1f7d1e5
Submitter: Jenkins
Branch: master

commit 5b7c71a327d735134fa0eeb4427d0e1bd1f7d1e5
Author: gaozhengwei <email address hidden>
Date: Wed Aug 31 23:11:10 2016 +0800

    Preventing iptables rule to be thrashed

    When update meter label or rule, iptables_manager will update iptables
    rule in router's namespace. In order to, it will clean traffic counter
    number collected in interval time, the other iptables always trashing
    that will clean old iptalbes rule and generate new same significance
    iptables rule.

    Change-Id: Ide2b26c98587258175234acded38ce481b7e7f76
    Closes-Bug: #1618879

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 9.0.0.0rc1

This issue was fixed in the openstack/neutron 9.0.0.0rc1 release candidate.

Revision history for this message
Jeremy Stanley (fungi) wrote :

I agree with Tristan, this looks like a security hardening opportunity.

Changed in ossa:
status: Incomplete → Won't Fix
information type: Public Security → Public
tags: added: security
tags: added: sg-fw
tags: added: metering
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/neutron 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.