Evergreen

Avoid uninit warning for prox_cache in open-ils.circ.hold.is_possible

Bug #1624491 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
Evergreen 2.12-beta
2.10
Fix Released
Undecided
Unassigned
Evergreen 2.10.8
2.11
Fix Released
Undecided
Unassigned
Evergreen 2.11.1

Bug Description

* Evergreen 2.10.6

Problem: logs show the following warning:

open-ils.circ: [WARN:32706:Application.pm:590:123456789] open-ils.circ.title_hold.is_possible: Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.18.2/OpenILS/Application/Circ/Holds.pm line 2616.

This is because values in the prox_cache hash are used in the logging message before they have been initialized. Let's log messages _after_ they are sure to have been initialized.

Tags: pullrequest
Revision history for this message
Dan Scott (denials) wrote :

Branch with one commit for a fix at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1624491_silence_prox_cache_uninit

tags: added: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

I've picked this into 2.10-master. Thanks, Dan!

Evergreen Bug Maintenance (bugmaster)
no longer affects: evergreen/master
Changed in evergreen:
milestone: 2.11.1 → 2.next
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.next → 2.12-beta
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.