No result view can cause launcher window to grow
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Granite |
Fix Committed
|
Low
|
Danielle Foré | ||
| Slingshot |
Won't Fix
|
Low
|
Unassigned | ||
Bug Description
The "No Result" view of Slingshot can cause the launcher's window to grow in size. The problem is that it stays that way. If you search for a long term that doesn't exist the window will just continue to grow to fit the text of the search term. After closing the launcher and re-opening the size of the launcher window will still be large.
There are a few different solutions I thought of for this.
1. Cut off the result text and use an ellipsis so that the window doesn't grow.
2. Resize the window back to it's original size after it is closed (probably triggered by a signal and you would need to clear the title text for the alert view).
3. Just don't display the result text in the window.
I think the 3rd solution is the best, personally. The search term is already in the search bar and there's no need to repeat it in the window. Just have the window display "No Results" seems like a cleaner solution.
You can view the problem in action here:
https:/
Related branches
- Danielle Foré: Disapprove
-
Diff: 11 lines (+1/-1)1 file modifiedsrc/Widgets/SearchView.vala (+1/-1)
- Zisu Andrei (community): Approve
- Matt Spaulding (community): Needs Fixing
-
Diff: 13 lines (+3/-0)1 file modifiedlib/Widgets/AlertView.vala (+3/-0)
| Changed in slingshot: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Danielle Foré (danrabbit) wrote | #1 |
| Changed in slingshot: | |
| status: | Confirmed → Won't Fix |
| Changed in granite: | |
| status: | New → Confirmed |
| milestone: | none → juno-beta1 |
| tags: | added: bitesize |
| Changed in granite: | |
| importance: | Undecided → Low |
| Changed in granite: | |
| assignee: | nobody → Daniel Fore (danrabbit) |
| status: | Confirmed → In Progress |
| Changed in granite: | |
| status: | In Progress → Fix Committed |
Moving this report to granite. We're using a Granite.Alertview here and the label for Alertview is not public, so what we need to do is set wrap to true in granite.
Since the label isn't public, we can't fix it in Slingshot. Marked as "Won't fix" for Slingshot.