Not Handling OSErrors
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Low
|
Phill | ||
Bug Description
We don't handle OSErrors. Things like "No space left on device" or "Permission denied (read only file)".
Traceback (most recent call last):
File "openlp/
File "openlp/
File "tempfile.py", line 278, in mkstemp
File "tempfile.py", line 207, in _mkstemp_inner
OSError: [Errno 28] No space left on device: '/var/folders/
Traceback (most recent call last):
File "D:\OpenLP_
File "D:\OpenLP_
File "c:\Python33\
File "c:\Python33\
PermissionError: [Errno 13] Permission denied: 'C:\\Users\
Related branches
- Tim Bentley: Approve
- Raoul Snyman: Approve
-
Diff: 682 lines (+181/-291)6 files modifiedopenlp/core/lib/serviceitem.py (+9/-8)
openlp/core/ui/mainwindow.py (+8/-6)
openlp/core/ui/servicemanager.py (+128/-241)
tests/functional/openlp_core/lib/test_serviceitem.py (+2/-1)
tests/functional/openlp_core/ui/test_mainwindow.py (+29/-2)
tests/functional/openlp_core/ui/test_servicemanager.py (+5/-33)
- Tim Bentley: Pending requested
-
Diff: 1333 lines (+187/-208)47 files modifiedopenlp/core/api/deploy.py (+2/-2)
openlp/core/app.py (+8/-4)
openlp/core/common/__init__.py (+2/-2)
openlp/core/common/path.py (+1/-1)
openlp/core/common/settings.py (+1/-1)
openlp/core/display/html/display.html (+1/-1)
openlp/core/display/html/display.js (+1/-1)
openlp/core/lib/__init__.py (+6/-8)
openlp/core/lib/db.py (+15/-11)
openlp/core/lib/mediamanageritem.py (+6/-6)
openlp/core/lib/serviceitem.py (+3/-3)
openlp/core/ui/advancedtab.py (+1/-1)
openlp/core/ui/exceptiondialog.py (+3/-3)
openlp/core/ui/exceptionform.py (+14/-7)
openlp/core/ui/generaltab.py (+0/-1)
openlp/core/ui/mainwindow.py (+1/-1)
openlp/core/ui/servicemanager.py (+13/-12)
openlp/core/ui/thememanager.py (+10/-10)
openlp/core/version.py (+1/-1)
openlp/core/widgets/edits.py (+1/-1)
openlp/core/widgets/wizard.py (+1/-41)
openlp/plugins/bibles/forms/bibleimportform.py (+2/-2)
openlp/plugins/bibles/lib/bibleimport.py (+2/-2)
openlp/plugins/bibles/lib/db.py (+6/-6)
openlp/plugins/bibles/lib/importers/wordproject.py (+1/-1)
openlp/plugins/bibles/lib/manager.py (+1/-1)
openlp/plugins/bibles/lib/mediaitem.py (+3/-3)
openlp/plugins/custom/lib/mediaitem.py (+3/-6)
openlp/plugins/images/lib/mediaitem.py (+3/-3)
openlp/plugins/media/lib/mediaitem.py (+7/-7)
openlp/plugins/presentations/lib/mediaitem.py (+3/-3)
openlp/plugins/presentations/lib/messagelistener.py (+2/-8)
openlp/plugins/songs/forms/songimportform.py (+7/-2)
openlp/plugins/songs/lib/importers/cclifile.py (+4/-3)
openlp/plugins/songs/lib/mediaitem.py (+2/-4)
openlp/plugins/songusage/forms/songusagedetailform.py (+2/-2)
run_openlp.py (+8/-2)
tests/functional/openlp_core/api/test_deploy.py (+2/-2)
tests/functional/openlp_core/common/test_init.py (+14/-8)
tests/functional/openlp_core/common/test_path.py (+3/-5)
tests/functional/openlp_core/lib/test_serviceitem.py (+4/-4)
tests/functional/openlp_core/ui/test_thememanager.py (+3/-3)
tests/functional/openlp_plugins/bibles/test_manager.py (+3/-2)
tests/interfaces/openlp_plugins/songs/forms/test_songmaintenanceform.py (+2/-2)
tests/openlp_core/common/test_network_interfaces.py (+1/-1)
tests/openlp_core/projectors/test_projector_pjlink_commands_01.py (+6/-6)
tests/openlp_core/projectors/test_projector_sourceform.py (+2/-2)
| Timothy Cooper (timothycooper) wrote | #1 |
| Changed in openlp: | |
| status: | New → Won't Fix |
| Raoul Snyman (raoul-snyman) wrote | #2 |
| Changed in openlp: | |
| status: | Won't Fix → Confirmed |
| Changed in openlp: | |
| importance: | Undecided → Low |
| Changed in openlp: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Phill (phill-ridout) |
| Changed in openlp: | |
| status: | In Progress → Fix Committed |
| Changed in openlp: | |
| milestone: | none → 2.9.1 |
The Traceback shown here came from our church's laptop (unless someone else also named their user account NCF-AV). I'll provide more info if requested. We currently use a Read Only system flag to prevent file "(template).oszl" from being accidentally overwritten (since OpenLP doesn't have Templates at this time).