bileto packaging diffs include anything that has 'debian' as a subpath

Bug #1651790 reported by Steve Langasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bileto
Fix Released
Undecided
Robert Bruce Park

Bug Description

Reviewing a packaging diff here:

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_39a8dbb93caf4ec889f8a1b7f69885db/bileto-2298/2016-12-15_09:09:58/zesty_oxide-qt_packaging_changes.diff

I saw that the diff included paths such as oxide-qt-1.17.9/chrome/installer/linux/debian/build.sh

This is clearly not part of the packaging, but appears to have been included in the packaging diff because there is *a* /debian/ directory as part of the path.

The debian/ filtering should be anchored to only the first-level debian/ subdir. If using filterdiff, this would be '*/debian/**' vs. '**/debian/**'.

Revision history for this message
Robert Bruce Park (robru) wrote :

We are using filterdiff but the current filter is '*debian/*' which suggests that filterdiff does not support ** vs * path-depth-aware globbing. I also can't find reference to any '**' in the manpage (though the manpage just says "--include=PATTERN" and never defines PATTERN).

I'll try your suggestion of '*/debian/**' and see what happens but I don't have much hope...

Revision history for this message
Robert Bruce Park (robru) wrote :

Ok, your suggested change is live in production and doesn't appear to have regressed anything, unfortunately the oxide ticket in question landed so i can't regenerate diffs there to confirm this is actually fixed.

Feel free to re open if you see this again

Changed in bileto:
status: New → Fix Released
assignee: nobody → Robert Bruce Park (robru)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.