OpenStack-Ansible

Changes in Ansible broke TASK [os_keystone : Set keystone_federated_identities fact]

Bug #1660626 reported by Ingemar Fällman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
High
Kevin Carter
OpenStack-Ansible 14.1.0

Bug Description

An exception occurred during task execution. The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_l9L6Li/ansible_module_keystone_sp.py", line 120, in <module>
    main()
  File "/tmp/ansible_l9L6Li/ansible_module_keystone_sp.py", line 117, in main
    module.fail_json(msg='Failed Process', **resp)
  File "/tmp/ansible_l9L6Li/ansible_modlib.zip/ansible/module_utils/basic.py", line 1812, in fail_json
  File "/tmp/ansible_l9L6Li/ansible_modlib.zip/ansible/module_utils/basic.py", line 388, in remove_values
  File "/tmp/ansible_l9L6Li/ansible_modlib.zip/ansible/module_utils/basic.py", line 388, in <genexpr>
  File "/tmp/ansible_l9L6Li/ansible_modlib.zip/ansible/module_utils/basic.py", line 399, in remove_values
TypeError: Value of unknown type: <type 'exceptions.TypeError'>, string indices must be integers, not str

fatal: [_keystone_container-da203646]: FAILED! => {
    "changed": false,
    "failed": true,
    "invocation": {
        "module_name": "keystone_sp"
    },
    "module_stderr": "Traceback (most recent call last):\n File \"/tmp/ansible_l9L6Li/ansible_module_keystone_sp.py\", line 120, in <module>\n main()\n File \"/tmp/ansible_l9L6Li/ansible_module_keystone_sp.py\", line 117, in main\n module.fail_json(msg='Failed Process', **resp)\n File \"/tmp/ansible_l9L6Li/ansible_modlib.zip/ansible/module_utils/basic.py\", line 1812, in fail_json\n File \"/tmp/ansible_l9L6Li/ansible_modlib.zip/ansible/module_utils/basic.py\", line 388, in remove_values\n File \"/tmp/ansible_l9L6Li/ansible_modlib.zip/ansible/module_utils/basic.py\", line 388, in <genexpr>\n File \"/tmp/ansible_l9L6Li/ansible_modlib.zip/ansible/module_utils/basic.py\", line 399, in remove_values\nTypeError: Value of unknown type: <type 'exceptions.TypeError'>, string indices must be integers, not str\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE"
}

self.module.params['sp_data'] returns string and not key value hash in
https://github.com/openstack/openstack-ansible-os_keystone/blob/master/library/keystone_sp#L82

You can reproduce this error with any keystone_sp config in user_variables.yml

Revision history for this message
Jean-Philippe Evrard (jean-philippe-evrard) wrote :

Waiting for a confirmation (cloudnull's ?)

Revision history for this message
Kevin Carter (kevin-carter) wrote :

confirmed. working more on this now.

Changed in openstack-ansible:
assignee: nobody → Kevin Carter (kevin-carter)
importance: Undecided → High
status: New → Confirmed
milestone: none → 14.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/430519

Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_keystone (master)

Reviewed: https://review.openstack.org/430519
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=a6ee6100c5c1dfc3c0657af19652e30d5bbdde74
Submitter: Jenkins
Branch: master

commit a6ee6100c5c1dfc3c0657af19652e30d5bbdde74
Author: Kevin Carter <email address hidden>
Date: Tue Feb 7 20:58:09 2017 -0600

    Resolved Keystone Federation bugs

    The keystone role needed a few updates to deal with modern Ansible.

      * The changeset pulls in the needed updates to resolve issues causing
        the keystone_sp plugin, which powers federation, to crash.
      * The changeset pulls in style changes for keystone cert sync removing
        the need for the role to leverage the now deprecated memcached key
        module.

    Closes-Bug: 1660626

    Change-Id: I29d444c9631a7511123aa6cd521a20a0e7588645
    Signed-off-by: Kevin Carter <email address hidden>

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_keystone (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/430841

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_keystone (stable/ocata)

Reviewed: https://review.openstack.org/430841
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=6f1403afac90871d4c19eddb3129f424492d7e47
Submitter: Jenkins
Branch: stable/ocata

commit 6f1403afac90871d4c19eddb3129f424492d7e47
Author: Kevin Carter <email address hidden>
Date: Tue Feb 7 20:58:09 2017 -0600

    Resolved Keystone Federation bugs

    The keystone role needed a few updates to deal with modern Ansible.

      * The changeset pulls in the needed updates to resolve issues causing
        the keystone_sp plugin, which powers federation, to crash.
      * The changeset pulls in style changes for keystone cert sync removing
        the need for the role to leverage the now deprecated memcached key
        module.

    Closes-Bug: 1660626

    Change-Id: I29d444c9631a7511123aa6cd521a20a0e7588645
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit a6ee6100c5c1dfc3c0657af19652e30d5bbdde74)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_keystone (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/431616

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_keystone (stable/newton)

Reviewed: https://review.openstack.org/431616
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=c212da66783d315b1ad4b78d4d2b9031a09a0d21
Submitter: Jenkins
Branch: stable/newton

commit c212da66783d315b1ad4b78d4d2b9031a09a0d21
Author: Kevin Carter <email address hidden>
Date: Tue Feb 7 20:58:09 2017 -0600

    Resolved Keystone Federation bugs

    The keystone role needed a few updates to deal with modern Ansible.

      * The changeset pulls in the needed updates to resolve issues causing
        the keystone_sp plugin, which powers federation, to crash.
      * The changeset pulls in style changes for keystone cert sync removing
        the need for the role to leverage the now deprecated memcached key
        module.

    Closes-Bug: 1660626

    Change-Id: I29d444c9631a7511123aa6cd521a20a0e7588645
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit a6ee6100c5c1dfc3c0657af19652e30d5bbdde74)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_keystone 14.1.0

This issue was fixed in the openstack/openstack-ansible-os_keystone 14.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_keystone 15.0.0.0rc2

This issue was fixed in the openstack/openstack-ansible-os_keystone 15.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_keystone 16.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_keystone 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.