Cinder

Backwards compatibility for oslo messaging in Cinder

Bug #1660928 reported by Alexey Weyl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Gorka Eguileor

Bug Description

Cinder needs to be backward compatible for oslo messaging.

More details can be seen here in the irc log from minute 09:15.
http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/%23openstack-cinder.2017-02-01.log.html

Revision history for this message
Gorka Eguileor (gorka) wrote :

I can confirm, the problem is that the short-circuiting patch for notifications [1] did not take into consideration pre Mitaka way of setting notifications.

[1] https://review.openstack.org/#/c/426547

Changed in cinder:
assignee: nobody → Gorka Eguileor (gorka)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/427647

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/427647
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e7171fd74a683a1118c03506ef1600333193abb5
Submitter: Jenkins
Branch: master

commit e7171fd74a683a1118c03506ef1600333193abb5
Author: Gorka Eguileor <email address hidden>
Date: Wed Feb 1 12:17:39 2017 +0100

    Fix notification short-circuit

    We recently introduced a mechanism to short-circuit notifications when
    they were disabled, unfortunately the mechanism was not backward
    compatible with deprecated oslo notification setup that defaults to use
    the transport mechanism of RPC.

    In Mitaka oslo messaging introduced the transport_url specific for
    notifications under the oslo_messaging_notifications section, but some
    projects still use the default transport_url defined in the DEFAULT
    section.

    This patch fixes the notification short-circuit, now we don't check the
    transport_url but the driver option in the oslo_messaging_notifications
    section, which is a more robust way of checking, since it is backward
    compatible.

    Change-Id: Iccf51756701759e3727d3d989bab08bc05cac9a7
    Closes-Bug: #1660928

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.0.0rc1

This issue was fixed in the openstack/cinder 10.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.