Evergreen

Web Client: Navigating from View Holds - Opac View - View Holds duplicates hold list

Bug #1669907 reported by Michele Morgan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.12.4

Bug Description

Evergreen 2.11+ web client

When viewing a record with holds, if the staff user navigates from View Holds to Opac View and back to View Holds, the list of holds is duplicated, giving the appearance of twice the number of holds than actually exist.

Here's a quick screencast illustrating the behavior:

https://www.screencast.com/t/42wdGITi

Revision history for this message
Cesar V (cesardv) wrote :

Possible fix for the duplication issue is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1669907_webstaff-view_holds_dups

Cesar V (cesardv)
tags: added: needstest
tags: added: pullrequest
Revision history for this message
Terran McCanna (tmccanna) wrote :

I'll test this during bug squashing week

Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Works for me!

I have tested this code and consent to signing off on it with my name, Terran McCanna and my email address, <email address hidden>.

tags: added: signedoff
removed: needstest
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
status: New → Confirmed
Galen Charlton (gmc)
Changed in evergreen:
milestone: none → 2.12.4
importance: Undecided → Medium
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_2_12. Thanks, Cesar and Terran.

I note that the underlying cause of the bug is that the grid provider.get() is getting called two times in quick succession when the user switch to the View Holds tab. That's, at minimum, inefficient, since the same set of holds is getting fetched twice. I'll open a separate bug.

Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.