Consolidate JS dependency install with npm

Bug #1680624 reported by Dan Scott
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

We currently use npm to install development dependencies and bower to install front end dependencies. While this reflected common practices a few years ago, many projects are now consolidating the two methods of installing dependencies by simply using npm. Removing one build step would remove one more potential source of errors.

Revision history for this message
Dan Scott (denials) wrote :

See http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1680624_bower_to_npm for a first stab at this. Tests pass, and there appear to be no regressions in the handful of staff client interfaces I've tried to date.

tags: added: staffclient
tags: added: webstaffclient
Revision history for this message
Dan Scott (denials) wrote :

Force-pushed the branch to incorporate changes that had been left in the middle of a rebase to add the bug prefix (jeez).

Revision history for this message
Dan Scott (denials) wrote :

Allow me to offer a regression test that will hopefully prevent these from showing up in the future!

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1680312_test_sql_gettext

Revision history for this message
Dan Scott (denials) wrote :

Ugh, wrong browser tab, wrong bug for that regression test.

Revision history for this message
Bill Erickson (berick) wrote :

Sign-offs for Dan's 2 NPM commits pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1680624-bower-to-npm-signoff

I removed the installed build directory and local bower/node files, re-ran "npm install" to fetch the deps. Tests passed. Copied build directory into place and various web staff UI's behaved as expected.

I didn't merge to master, thinking it might be good to test the branch on a fresh install, which I have not done.

Changed in evergreen:
status: New → Confirmed
tags: added: signedoff
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.0-alpha
Revision history for this message
Bill Erickson (berick) wrote :

Noted by Ben Shum in IRC, we should also remove the bower install bits from the various installer makefiles.

tags: removed: pullrequest signedoff
Revision history for this message
Dan Scott (denials) wrote :

Excellent point! I shall work on removing those remaining bits.

And I have, with a new branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1680624-bower-to-npm that includes Bill's signoffs on the first two commits and a follow-up with the bower package install and release building bits.

I *think* that's it!

Aside: at some point in the 3.0 cycle we should remove the file-saver and sortable directories in Open-ILS/web/js and just use npm to pull those in, too.

tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Test install from scratch worked for me, working web client too. Picked everything to master, cool stuff!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.