upgrade angular-ui-bootstrap to at least 1.3.3

Bug #1682609 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

We're currently using 1.2.4 of angular-ui-bootstrap. The general reason for upgrading to 1.3.3 is just the normal keeping on top of things. However, there's also a specific motivation: taking advantage of uib-tab's new ability to use arbitrary (and hopefully more semantic) strings as indexes rather than just integers.

Here are the list of potentially relevant breaking changes gleaned from the release notes between 1.2.4 and 1.3.3:

* timepicker: This removes automatic padding done by the timepicker when the input is empty - if that behavior is desired, write a custom directive implementing it
* dropdown: The dropdown no longer will remain open on $locationChangeSuccess with autoclose set to disabled. Implement this logic inside app along with usage of isOpen two-way binding if this functionality is desired.
* datepickerPopup: The datepicker popup is no longer a part of the datepicker module, but now a part of the datepickerPopup module. Please change code accordingly if including specific modules
* datepicker: This removes inline datepicker attribute support and attribute pass-throughs in the popup
* dropdown: Stops propagation of keydown event when escape key is pressed. Removes keydown event from the document and moves it to the dropdown element.
* modal: Since this adds support for $resolve being exposed on $scope, it could potentially overwrite any pre-existing usage of it - this is an unlikely scenario, but marked as a breaking change in case this key is being used

As far as I can tell, there's major nothing stopping us from going past 1.3.3 and up to 2.5.0+, just a lot more breaking changes to double-check.

Evergreen master

Revision history for this message
Galen Charlton (gmc) wrote :

A patch for this is included in the branch for the web staff client's serial module; please see bug 1708291.

Changed in evergreen:
milestone: none → 3.0-alpha
Revision history for this message
Evergreen Bug Maintenance (bugmaster) wrote :

Included as part of the serials branch; marking fixed-released.

Changed in evergreen:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.